From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: johan.hedberg@gmail.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/6] Bluetooth: mgmt: Allow connectable/discoverable changes in off state
Date: Wed, 22 Feb 2012 10:05:52 +0200 [thread overview]
Message-ID: <20120222080549.GC24328@aemeltch-MOBL1> (raw)
In-Reply-To: <1329846229-7919-1-git-send-email-johan.hedberg@gmail.com>
Hi Johan,
On Tue, Feb 21, 2012 at 07:43:44PM +0200, johan.hedberg@gmail.com wrote:
> From: Johan Hedberg <johan.hedberg@intel.com>
>
> This patch makes it possible to toggle the connectable & discoverable
> settings when powered off. Two new hdev->dev_flags flags are added to
> track what the scan mode should be when the device is finally powered
> on.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
...
> +
> + if (!!cp->val == test_bit(HCI_DISCOVERABLE, &hdev->dev_flags)) {
Is this really the best we can do? Also applies to other similar code.
Best regards
Andrei Emeltchenko
prev parent reply other threads:[~2012-02-22 8:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 17:43 [PATCH 1/6] Bluetooth: mgmt: Allow connectable/discoverable changes in off state johan.hedberg
2012-02-21 17:43 ` [PATCH 2/6] Bluetooth: mgmt: Fix Removing discoverable timeout in set_connectable johan.hedberg
2012-02-22 8:09 ` Andrei Emeltchenko
2012-02-21 17:43 ` [PATCH 3/6] Bluetooth: mgmt: Fix current settings values when powered off johan.hedberg
2012-02-21 17:43 ` [PATCH 4/6] Bluetooth: mgmt: Add convenience function for sending New Settings johan.hedberg
2012-02-21 17:43 ` [PATCH 5/6] Bluetooth: mgmt: Fix New Settings event for connectable/discoverable johan.hedberg
2012-02-21 17:43 ` [PATCH 6/6] Bluetooth: Fix clearing of persistent dev_flags johan.hedberg
2012-02-22 8:05 ` Andrei Emeltchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222080549.GC24328@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).