* [patch] Bluetooth: use kfree_skb() instead of kfree()
@ 2012-02-28 6:52 Dan Carpenter
2012-02-28 7:57 ` Andrei Emeltchenko
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-02-28 6:52 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Gustavo F. Padovan, Andrei Emeltchenko, linux-bluetooth,
kernel-janitors
sk_buffs should be freed using kfree_skb().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index bdcfbf0..df3be69 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -4284,7 +4284,7 @@ static inline int l2cap_data_channel(struct l2cap_conn *conn, u16 cid, struct sk
if (!chan) {
BT_DBG("unknown cid 0x%4.4x", cid);
/* Drop packet and return */
- kfree(skb);
+ kfree_skb(skb);
return 0;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] Bluetooth: use kfree_skb() instead of kfree()
2012-02-28 6:52 [patch] Bluetooth: use kfree_skb() instead of kfree() Dan Carpenter
@ 2012-02-28 7:57 ` Andrei Emeltchenko
2012-02-28 16:19 ` Marcel Holtmann
2012-03-01 1:39 ` Johan Hedberg
2 siblings, 0 replies; 4+ messages in thread
From: Andrei Emeltchenko @ 2012-02-28 7:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: Marcel Holtmann, Gustavo F. Padovan, linux-bluetooth,
kernel-janitors
On Tue, Feb 28, 2012 at 09:52:46AM +0300, Dan Carpenter wrote:
> sk_buffs should be freed using kfree_skb().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Sorry missed that.
Acked-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index bdcfbf0..df3be69 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -4284,7 +4284,7 @@ static inline int l2cap_data_channel(struct l2cap_conn *conn, u16 cid, struct sk
> if (!chan) {
> BT_DBG("unknown cid 0x%4.4x", cid);
> /* Drop packet and return */
> - kfree(skb);
> + kfree_skb(skb);
> return 0;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] Bluetooth: use kfree_skb() instead of kfree()
2012-02-28 6:52 [patch] Bluetooth: use kfree_skb() instead of kfree() Dan Carpenter
2012-02-28 7:57 ` Andrei Emeltchenko
@ 2012-02-28 16:19 ` Marcel Holtmann
2012-03-01 1:39 ` Johan Hedberg
2 siblings, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2012-02-28 16:19 UTC (permalink / raw)
To: Dan Carpenter
Cc: Gustavo F. Padovan, Andrei Emeltchenko, linux-bluetooth,
kernel-janitors
Hi Dan,
> sk_buffs should be freed using kfree_skb().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
sadly these keep slipping in every now and then.
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] Bluetooth: use kfree_skb() instead of kfree()
2012-02-28 6:52 [patch] Bluetooth: use kfree_skb() instead of kfree() Dan Carpenter
2012-02-28 7:57 ` Andrei Emeltchenko
2012-02-28 16:19 ` Marcel Holtmann
@ 2012-03-01 1:39 ` Johan Hedberg
2 siblings, 0 replies; 4+ messages in thread
From: Johan Hedberg @ 2012-03-01 1:39 UTC (permalink / raw)
To: Dan Carpenter
Cc: Marcel Holtmann, Gustavo F. Padovan, Andrei Emeltchenko,
linux-bluetooth, kernel-janitors
Hi Dan,
On Tue, Feb 28, 2012, Dan Carpenter wrote:
> sk_buffs should be freed using kfree_skb().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index bdcfbf0..df3be69 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -4284,7 +4284,7 @@ static inline int l2cap_data_channel(struct l2cap_conn *conn, u16 cid, struct sk
> if (!chan) {
> BT_DBG("unknown cid 0x%4.4x", cid);
> /* Drop packet and return */
> - kfree(skb);
> + kfree_skb(skb);
> return 0;
> }
Applied to my bluetooth-next tree. Thanks.
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-01 1:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-28 6:52 [patch] Bluetooth: use kfree_skb() instead of kfree() Dan Carpenter
2012-02-28 7:57 ` Andrei Emeltchenko
2012-02-28 16:19 ` Marcel Holtmann
2012-03-01 1:39 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).