From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
"Gustavo F. Padovan" <padovan@profusion.mobi>,
linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] Bluetooth: use kfree_skb() instead of kfree()
Date: Tue, 28 Feb 2012 09:57:22 +0200 [thread overview]
Message-ID: <20120228075720.GA4381@aemeltch-MOBL1> (raw)
In-Reply-To: <20120228065246.GC20506@elgon.mountain>
On Tue, Feb 28, 2012 at 09:52:46AM +0300, Dan Carpenter wrote:
> sk_buffs should be freed using kfree_skb().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Sorry missed that.
Acked-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index bdcfbf0..df3be69 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -4284,7 +4284,7 @@ static inline int l2cap_data_channel(struct l2cap_conn *conn, u16 cid, struct sk
> if (!chan) {
> BT_DBG("unknown cid 0x%4.4x", cid);
> /* Drop packet and return */
> - kfree(skb);
> + kfree_skb(skb);
> return 0;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next prev parent reply other threads:[~2012-02-28 7:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 6:52 [patch] Bluetooth: use kfree_skb() instead of kfree() Dan Carpenter
2012-02-28 7:57 ` Andrei Emeltchenko [this message]
2012-02-28 16:19 ` Marcel Holtmann
2012-03-01 1:39 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120228075720.GA4381@aemeltch-MOBL1 \
--to=andrei.emeltchenko@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).