From: Johan Hedberg <johan.hedberg@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
"Gustavo F. Padovan" <padovan@profusion.mobi>,
Andrei Emeltchenko <andrei.emeltchenko@intel.com>,
linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] Bluetooth: use kfree_skb() instead of kfree()
Date: Wed, 29 Feb 2012 19:39:49 -0600 [thread overview]
Message-ID: <20120301013949.GB26492@x220> (raw)
In-Reply-To: <20120228065246.GC20506@elgon.mountain>
Hi Dan,
On Tue, Feb 28, 2012, Dan Carpenter wrote:
> sk_buffs should be freed using kfree_skb().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index bdcfbf0..df3be69 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -4284,7 +4284,7 @@ static inline int l2cap_data_channel(struct l2cap_conn *conn, u16 cid, struct sk
> if (!chan) {
> BT_DBG("unknown cid 0x%4.4x", cid);
> /* Drop packet and return */
> - kfree(skb);
> + kfree_skb(skb);
> return 0;
> }
Applied to my bluetooth-next tree. Thanks.
Johan
prev parent reply other threads:[~2012-03-01 1:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 6:52 [patch] Bluetooth: use kfree_skb() instead of kfree() Dan Carpenter
2012-02-28 7:57 ` Andrei Emeltchenko
2012-02-28 16:19 ` Marcel Holtmann
2012-03-01 1:39 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301013949.GB26492@x220 \
--to=johan.hedberg@gmail.com \
--cc=andrei.emeltchenko@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).