linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 1/6] core: Make adapter_ops->set_discoverable to take discoverable timeout
Date: Wed, 29 Feb 2012 19:43:23 -0600	[thread overview]
Message-ID: <20120301014323.GD26492@x220> (raw)
In-Reply-To: <1330428206-8185-1-git-send-email-luiz.dentz@gmail.com>

Hi Luiz,

On Tue, Feb 28, 2012, Luiz Augusto von Dentz wrote:
> This enables the driver to implements its own handling of the timeout
> ---
>  src/adapter.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/src/adapter.h b/src/adapter.h
> index 22bb0bb..7acd14d 100644
> --- a/src/adapter.h
> +++ b/src/adapter.h
> @@ -181,7 +181,8 @@ struct btd_adapter_ops {
>  	int (*setup) (void);
>  	void (*cleanup) (void);
>  	int (*set_powered) (int index, gboolean powered);
> -	int (*set_discoverable) (int index, gboolean discoverable);
> +	int (*set_discoverable) (int index, gboolean discoverable,
> +							uint16_t timeout);
>  	int (*set_pairable) (int index, gboolean pairable);
>  	int (*set_limited_discoverable) (int index, gboolean limited);
>  	int (*start_discovery) (int index);

This would seem to introduce compilation breakage. Could you at least
do the necessary changes to hciops and mgmtops that this compiles. If
you prefer to have the moved functionality as a separate patch thats
fine but at least add the necessary new parameters to these function.

Johan

      parent reply	other threads:[~2012-03-01  1:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 11:23 [PATCH BlueZ 1/6] core: Make adapter_ops->set_discoverable to take discoverable timeout Luiz Augusto von Dentz
2012-02-28 11:23 ` [PATCH BlueZ 2/6] hciops: Add discoverable timeout logic Luiz Augusto von Dentz
2012-02-28 11:23 ` [PATCH BlueZ 3/6] mgmtops: Add timeout to set_discoverable callback Luiz Augusto von Dentz
2012-02-28 11:23 ` [PATCH BlueZ 4/6] core: remove set_limited_discoverable from adapter_ops driver Luiz Augusto von Dentz
2012-03-01  1:46   ` Johan Hedberg
2012-02-28 11:23 ` [PATCH BlueZ 5/6] hciops: Remove set_limited_discoverable callback Luiz Augusto von Dentz
2012-02-28 11:23 ` [PATCH BlueZ 6/6] mgmtops: " Luiz Augusto von Dentz
2012-03-01  1:43 ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120301014323.GD26492@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).