From: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 4/6] core: remove set_limited_discoverable from adapter_ops driver
Date: Wed, 29 Feb 2012 19:46:00 -0600 [thread overview]
Message-ID: <20120301014600.GE26492@x220> (raw)
In-Reply-To: <1330428206-8185-4-git-send-email-luiz.dentz@gmail.com>
Hi Luiz,
On Tue, Feb 28, 2012, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> Core should not longer need to take care of details of discoverable bits
> ---
> src/adapter.c | 8 --------
> src/adapter.h | 1 -
> 2 files changed, 0 insertions(+), 9 deletions(-)
>
> diff --git a/src/adapter.c b/src/adapter.c
> index 208f4c8..c5f4d0d 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -206,14 +206,6 @@ static uint8_t get_mode(const bdaddr_t *bdaddr, const char *mode)
> return MODE_UNKNOWN;
> }
>
> -static void adapter_set_limited_discoverable(struct btd_adapter *adapter,
> - gboolean limited)
> -{
> - DBG("%s", limited ? "TRUE" : "FALSE");
> -
> - adapter_ops->set_limited_discoverable(adapter->dev_id, limited);
> -}
> -
> static struct session_req *session_ref(struct session_req *req)
> {
> req->refcount++;
> diff --git a/src/adapter.h b/src/adapter.h
> index 611e86f..345e308 100644
> --- a/src/adapter.h
> +++ b/src/adapter.h
> @@ -186,7 +186,6 @@ struct btd_adapter_ops {
> int (*set_discoverable) (int index, gboolean discoverable,
> uint16_t timeout);
> int (*set_pairable) (int index, gboolean pairable);
> - int (*set_limited_discoverable) (int index, gboolean limited);
> int (*start_discovery) (int index);
> int (*stop_discovery) (int index);
This would also seem to introduce compilation breakage. Just remove the
mgmtops and hciops functions in the same go.
Johan
next prev parent reply other threads:[~2012-03-01 1:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 11:23 [PATCH BlueZ 1/6] core: Make adapter_ops->set_discoverable to take discoverable timeout Luiz Augusto von Dentz
2012-02-28 11:23 ` [PATCH BlueZ 2/6] hciops: Add discoverable timeout logic Luiz Augusto von Dentz
2012-02-28 11:23 ` [PATCH BlueZ 3/6] mgmtops: Add timeout to set_discoverable callback Luiz Augusto von Dentz
2012-02-28 11:23 ` [PATCH BlueZ 4/6] core: remove set_limited_discoverable from adapter_ops driver Luiz Augusto von Dentz
2012-03-01 1:46 ` Johan Hedberg [this message]
2012-02-28 11:23 ` [PATCH BlueZ 5/6] hciops: Remove set_limited_discoverable callback Luiz Augusto von Dentz
2012-02-28 11:23 ` [PATCH BlueZ 6/6] mgmtops: " Luiz Augusto von Dentz
2012-03-01 1:43 ` [PATCH BlueZ 1/6] core: Make adapter_ops->set_discoverable to take discoverable timeout Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301014600.GE26492@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).