linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Adding USB device 13d3:3375 (a bluetooth module embedded in the Asus UX31) as an Atheros AR3012 device.
@ 2011-11-23 10:03 eran
  2011-11-23 19:05 ` Vinicius Costa Gomes
  0 siblings, 1 reply; 7+ messages in thread
From: eran @ 2011-11-23 10:03 UTC (permalink / raw)
  To: linux-bluetooth

From: Eran <eran@over-here.org>

The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012 and requires a firmware to be uploaded before it's usable.

Signed-off-by: Eran <eran@over-here.org>
---
 drivers/bluetooth/ath3k.c |    2 ++
 drivers/bluetooth/btusb.c |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
index 106beb1..b94aae6 100644
--- a/drivers/bluetooth/ath3k.c
+++ b/drivers/bluetooth/ath3k.c
@@ -70,6 +70,7 @@ static struct usb_device_id ath3k_table[] = {
 
 	/* Atheros AR3012 with sflash firmware*/
 	{ USB_DEVICE(0x0CF3, 0x3004) },
+	{ USB_DEVICE(0x13d3, 0x3375) },
 
 	/* Atheros AR5BBU12 with sflash firmware */
 	{ USB_DEVICE(0x0489, 0xE02C) },
@@ -86,6 +87,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {
 
 	/* Atheros AR3012 with sflash firmware*/
 	{ USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
+	{ USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
 
 	{ }	/* Terminating entry */
 };
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index f9b7260..a64f15a 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -122,6 +122,7 @@ static struct usb_device_id blacklist_table[] = {
 
 	/* Atheros 3012 with sflash firmware */
 	{ USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
+	{ USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
 
 	/* Atheros AR5BBU12 with sflash firmware */
 	{ USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] Adding USB device 13d3:3375 (a bluetooth module embedded in the Asus UX31) as an Atheros AR3012 device.
  2011-11-23 10:03 [PATCH] Adding USB device 13d3:3375 (a bluetooth module embedded in the Asus UX31) as an Atheros AR3012 device eran
@ 2011-11-23 19:05 ` Vinicius Costa Gomes
  2011-11-24 11:19   ` [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012 eran
  2011-12-05 22:15   ` eran
  0 siblings, 2 replies; 7+ messages in thread
From: Vinicius Costa Gomes @ 2011-11-23 19:05 UTC (permalink / raw)
  To: eran; +Cc: linux-bluetooth

Hi Eran,

Just a few cosmetic comments, and a disclaimer: I don't have any
idea why it seems that every new Atheros device needs another
entry in those tables.

Apart from those minor points it looks good.

On 10:03 Wed 23 Nov, eran wrote:
> From: Eran <eran@over-here.org>

Keep the subject line shorter, under 60 or so characters, i.e. remove
the part between parentheses. And prefix your subject with "Bluetooth:".

> 
> The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012 and requires a firmware to be uploaded before it's usable.

Please break the comment at 70 or so characters.

> 
> Signed-off-by: Eran <eran@over-here.org>
> ---
>  drivers/bluetooth/ath3k.c |    2 ++
>  drivers/bluetooth/btusb.c |    1 +
>  2 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> index 106beb1..b94aae6 100644
> --- a/drivers/bluetooth/ath3k.c
> +++ b/drivers/bluetooth/ath3k.c
> @@ -70,6 +70,7 @@ static struct usb_device_id ath3k_table[] = {
>  
>  	/* Atheros AR3012 with sflash firmware*/
>  	{ USB_DEVICE(0x0CF3, 0x3004) },
> +	{ USB_DEVICE(0x13d3, 0x3375) },
>  
>  	/* Atheros AR5BBU12 with sflash firmware */
>  	{ USB_DEVICE(0x0489, 0xE02C) },
> @@ -86,6 +87,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {
>  
>  	/* Atheros AR3012 with sflash firmware*/
>  	{ USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
> +	{ USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
>  
>  	{ }	/* Terminating entry */
>  };
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index f9b7260..a64f15a 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -122,6 +122,7 @@ static struct usb_device_id blacklist_table[] = {
>  
>  	/* Atheros 3012 with sflash firmware */
>  	{ USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
> +	{ USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
>  
>  	/* Atheros AR5BBU12 with sflash firmware */
>  	{ USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },
> -- 
> 1.7.2.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Cheers,
-- 
Vinicius

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012.
  2011-11-23 19:05 ` Vinicius Costa Gomes
@ 2011-11-24 11:19   ` eran
  2011-12-02 11:15     ` Gustavo Padovan
  2011-12-05 22:15   ` eran
  1 sibling, 1 reply; 7+ messages in thread
From: eran @ 2011-11-24 11:19 UTC (permalink / raw)
  To: Vinicius Costa Gomes; +Cc: linux-bluetooth

From: Eran <eran@over-here.org>

The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012
and requires a firmware to be uploaded before it's usable.

Signed-off-by: Eran <eran@over-here.org>
---
 drivers/bluetooth/ath3k.c |    2 ++
 drivers/bluetooth/btusb.c |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
index 106beb1..b94aae6 100644
--- a/drivers/bluetooth/ath3k.c
+++ b/drivers/bluetooth/ath3k.c
@@ -70,6 +70,7 @@ static struct usb_device_id ath3k_table[] = {
 
 	/* Atheros AR3012 with sflash firmware*/
 	{ USB_DEVICE(0x0CF3, 0x3004) },
+	{ USB_DEVICE(0x13d3, 0x3375) },
 
 	/* Atheros AR5BBU12 with sflash firmware */
 	{ USB_DEVICE(0x0489, 0xE02C) },
@@ -86,6 +87,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {
 
 	/* Atheros AR3012 with sflash firmware*/
 	{ USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
+	{ USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
 
 	{ }	/* Terminating entry */
 };
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index f9b7260..a64f15a 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -122,6 +122,7 @@ static struct usb_device_id blacklist_table[] = {
 
 	/* Atheros 3012 with sflash firmware */
 	{ USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
+	{ USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
 
 	/* Atheros AR5BBU12 with sflash firmware */
 	{ USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },
-- 
1.7.2.5



On Wed, Nov 23, 2011 at 04:05:00PM -0300, Vinicius Costa Gomes wrote:
> Hi Eran,
> 
> Just a few cosmetic comments, and a disclaimer: I don't have any
> idea why it seems that every new Atheros device needs another
> entry in those tables.
> 
> Apart from those minor points it looks good.
> 
> On 10:03 Wed 23 Nov, eran wrote:
> > From: Eran <eran@over-here.org>
> 
> Keep the subject line shorter, under 60 or so characters, i.e. remove
> the part between parentheses. And prefix your subject with "Bluetooth:".
> 
> > 
> > The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012 and requires a firmware to be uploaded before it's usable.
> 
> Please break the comment at 70 or so characters.
> 
> > 
> > Signed-off-by: Eran <eran@over-here.org>
> > ---
> >  drivers/bluetooth/ath3k.c |    2 ++
> >  drivers/bluetooth/btusb.c |    1 +
> >  2 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> > index 106beb1..b94aae6 100644
> > --- a/drivers/bluetooth/ath3k.c
> > +++ b/drivers/bluetooth/ath3k.c
> > @@ -70,6 +70,7 @@ static struct usb_device_id ath3k_table[] = {
> >  
> >  	/* Atheros AR3012 with sflash firmware*/
> >  	{ USB_DEVICE(0x0CF3, 0x3004) },
> > +	{ USB_DEVICE(0x13d3, 0x3375) },
> >  
> >  	/* Atheros AR5BBU12 with sflash firmware */
> >  	{ USB_DEVICE(0x0489, 0xE02C) },
> > @@ -86,6 +87,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {
> >  
> >  	/* Atheros AR3012 with sflash firmware*/
> >  	{ USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
> > +	{ USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
> >  
> >  	{ }	/* Terminating entry */
> >  };
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index f9b7260..a64f15a 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -122,6 +122,7 @@ static struct usb_device_id blacklist_table[] = {
> >  
> >  	/* Atheros 3012 with sflash firmware */
> >  	{ USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
> > +	{ USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
> >  
> >  	/* Atheros AR5BBU12 with sflash firmware */
> >  	{ USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },
> > -- 
> > 1.7.2.5
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> Cheers,
> -- 
> Vinicius

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012.
  2011-11-24 11:19   ` [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012 eran
@ 2011-12-02 11:15     ` Gustavo Padovan
  0 siblings, 0 replies; 7+ messages in thread
From: Gustavo Padovan @ 2011-12-02 11:15 UTC (permalink / raw)
  To: eran; +Cc: Vinicius Costa Gomes, linux-bluetooth

Hi Eran,

* eran <eran@over-here.org> [2011-11-24 11:19:08 +0000]:

> From: Eran <eran@over-here.org>
> 
> The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012
> and requires a firmware to be uploaded before it's usable.
> 
> Signed-off-by: Eran <eran@over-here.org>
> ---
>  drivers/bluetooth/ath3k.c |    2 ++
>  drivers/bluetooth/btusb.c |    1 +
>  2 files changed, 3 insertions(+), 0 deletions(-)

Please also add the output of the usb-devices scripts related to this device,
then you can prove in the commit message that your change is really needed.

	Gustavo

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012.
  2011-11-23 19:05 ` Vinicius Costa Gomes
  2011-11-24 11:19   ` [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012 eran
@ 2011-12-05 22:15   ` eran
  2012-01-17 11:04     ` Michal Labedzki
  2012-03-08  5:17     ` Gustavo Padovan
  1 sibling, 2 replies; 7+ messages in thread
From: eran @ 2011-12-05 22:15 UTC (permalink / raw)
  To: Vinicius Costa Gomes, linux-bluetooth

From: Eran <eran@over-here.org>

The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012
and requires a firmware to be uploaded before it's usable.

output of usb-devices for this module:
T:  Bus=01 Lev=02 Prnt=02 Port=07 Cnt=03 Dev#=  6 Spd=12  MxCh= 0
D:  Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=13d3 ProdID=3375 Rev=00.02
S:  Manufacturer=Atheros Communications
S:  Product=Bluetooth USB Host Controller
S:  SerialNumber=Alaska Day 2006
C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
I:  If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb


Signed-off-by: Eran <eran@over-here.org>
---
 drivers/bluetooth/ath3k.c |    2 ++
 drivers/bluetooth/btusb.c |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
index 106beb1..b94aae6 100644
--- a/drivers/bluetooth/ath3k.c
+++ b/drivers/bluetooth/ath3k.c
@@ -70,6 +70,7 @@ static struct usb_device_id ath3k_table[] = {
 
 	/* Atheros AR3012 with sflash firmware*/
 	{ USB_DEVICE(0x0CF3, 0x3004) },
+	{ USB_DEVICE(0x13d3, 0x3375) },
 
 	/* Atheros AR5BBU12 with sflash firmware */
 	{ USB_DEVICE(0x0489, 0xE02C) },
@@ -86,6 +87,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {
 
 	/* Atheros AR3012 with sflash firmware*/
 	{ USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
+	{ USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
 
 	{ }	/* Terminating entry */
 };
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index f9b7260..a64f15a 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -122,6 +122,7 @@ static struct usb_device_id blacklist_table[] = {
 
 	/* Atheros 3012 with sflash firmware */
 	{ USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
+	{ USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
 
 	/* Atheros AR5BBU12 with sflash firmware */
 	{ USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012.
  2011-12-05 22:15   ` eran
@ 2012-01-17 11:04     ` Michal Labedzki
  2012-03-08  5:17     ` Gustavo Padovan
  1 sibling, 0 replies; 7+ messages in thread
From: Michal Labedzki @ 2012-01-17 11:04 UTC (permalink / raw)
  To: linux-bluetooth

I verified this patch. It is works and seems to be correct. 
Please apply it. Tested on UX21 with/without patch and with/without 
firmware (from latest linux-firmware).

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012.
  2011-12-05 22:15   ` eran
  2012-01-17 11:04     ` Michal Labedzki
@ 2012-03-08  5:17     ` Gustavo Padovan
  1 sibling, 0 replies; 7+ messages in thread
From: Gustavo Padovan @ 2012-03-08  5:17 UTC (permalink / raw)
  To: eran; +Cc: Vinicius Costa Gomes, linux-bluetooth

Hi Eran,

* eran <eran@over-here.org> [2011-12-05 22:15:29 +0000]:

> From: Eran <eran@over-here.org>
> 
> The bluetooth module in the Asus UX31/UX21 is based on Atheros AR3012
> and requires a firmware to be uploaded before it's usable.
> 
> output of usb-devices for this module:
> T:  Bus=01 Lev=02 Prnt=02 Port=07 Cnt=03 Dev#=  6 Spd=12  MxCh= 0
> D:  Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=13d3 ProdID=3375 Rev=00.02
> S:  Manufacturer=Atheros Communications
> S:  Product=Bluetooth USB Host Controller
> S:  SerialNumber=Alaska Day 2006
> C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
> I:  If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> I:  If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb

I applied this patch now, thanks.

	Gustavo

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2012-03-08  5:17 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-23 10:03 [PATCH] Adding USB device 13d3:3375 (a bluetooth module embedded in the Asus UX31) as an Atheros AR3012 device eran
2011-11-23 19:05 ` Vinicius Costa Gomes
2011-11-24 11:19   ` [PATCH] Bluetooth: Adding USB device 13d3:3375 as an Atheros AR3012 eran
2011-12-02 11:15     ` Gustavo Padovan
2011-12-05 22:15   ` eran
2012-01-17 11:04     ` Michal Labedzki
2012-03-08  5:17     ` Gustavo Padovan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).