linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH BlueZ] attrib-server: Fix sending "not supported" for indications/notifications
@ 2012-03-14 22:07 Vinicius Costa Gomes
  2012-03-16 15:23 ` Johan Hedberg
  0 siblings, 1 reply; 2+ messages in thread
From: Vinicius Costa Gomes @ 2012-03-14 22:07 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Vinicius Costa Gomes

Now that our Attribute Client is able to handle notifications and
indications we don't need to respond that they are not supported.
---
 src/attrib-server.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/attrib-server.c b/src/attrib-server.c
index 6268fe4..5775861 100644
--- a/src/attrib-server.c
+++ b/src/attrib-server.c
@@ -981,6 +981,10 @@ static void channel_handler(const uint8_t *ipdu, uint16_t len,
 		break;
 	case ATT_OP_HANDLE_CNF:
 		return;
+	case ATT_OP_HANDLE_IND:
+	case ATT_OP_HANDLE_NOTIFY:
+		/* The attribute client is already handling these */
+		return;
 	case ATT_OP_READ_MULTI_REQ:
 	case ATT_OP_PREP_WRITE_REQ:
 	case ATT_OP_EXEC_WRITE_REQ:
-- 
1.7.9.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH BlueZ] attrib-server: Fix sending "not supported" for indications/notifications
  2012-03-14 22:07 [PATCH BlueZ] attrib-server: Fix sending "not supported" for indications/notifications Vinicius Costa Gomes
@ 2012-03-16 15:23 ` Johan Hedberg
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2012-03-16 15:23 UTC (permalink / raw)
  To: Vinicius Costa Gomes; +Cc: linux-bluetooth

Hi Vinicius,

On Wed, Mar 14, 2012, Vinicius Costa Gomes wrote:
> Now that our Attribute Client is able to handle notifications and
> indications we don't need to respond that they are not supported.
> ---
>  src/attrib-server.c |    4 ++++
>  1 file changed, 4 insertions(+)

Applied. Thanks.

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-16 15:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-14 22:07 [PATCH BlueZ] attrib-server: Fix sending "not supported" for indications/notifications Vinicius Costa Gomes
2012-03-16 15:23 ` Johan Hedberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).