From: Johan Hedberg <johan.hedberg@gmail.com>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
padovan@profusion.mobi
Subject: Re: [PATCH] Bluetooth: Remove redundant hdev->parent field
Date: Fri, 16 Mar 2012 12:26:59 -0300 [thread overview]
Message-ID: <20120316152659.GG20650@x220> (raw)
In-Reply-To: <1331304822-426-1-git-send-email-dh.herrmann@googlemail.com>
Hi David,
On Fri, Mar 09, 2012, David Herrmann wrote:
> We initialize the "struct device" in hci_alloc_dev() for a long time now
> so we can access hdev->dev.parent directly. Hence, we can drop the
> temporary field hdev->parent which is used in no other place than
> hci_add_sysfs().
>
> SET_HCIDEV_DEV() is never called after registering a device by the drivers
> so we do not overwrite internal device-state. Furthermore, hdev->dev is
> initialized to 0 by kzalloc() inside hci_alloc_dev() so the default
> behavior with dev.parent = NULL is kept.
>
> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
> ---
> drivers/bluetooth/hci_ldisc.c | 2 +-
> include/net/bluetooth/hci_core.h | 3 +--
> net/bluetooth/hci_sysfs.c | 1 -
> 3 files changed, 2 insertions(+), 4 deletions(-)
Applied to my bluetooth-next tree. Thanks.
Johan
prev parent reply other threads:[~2012-03-16 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 14:53 [PATCH] Bluetooth: Remove redundant hdev->parent field David Herrmann
2012-03-09 17:12 ` Marcel Holtmann
2012-03-16 15:26 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120316152659.GG20650@x220 \
--to=johan.hedberg@gmail.com \
--cc=dh.herrmann@googlemail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox