From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: trivial: Remove sparse warnings
Date: Fri, 16 Mar 2012 12:36:30 -0300 [thread overview]
Message-ID: <20120316153630.GB21335@x220> (raw)
In-Reply-To: <1331626715-23685-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
On Tue, Mar 13, 2012, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> Fix sparse warnings related to incorrect type in assignment and static symbol.
> Also use const keyword. Warnings are shown below:
>
> ...
> net/bluetooth/mgmt.c:305:28: warning: incorrect type in assignment
> (different base types)
> net/bluetooth/mgmt.c:305:28: expected unsigned short [usertype] *opcode
> net/bluetooth/mgmt.c:305:28: got restricted __le16 *<noident>
> ...
> net/bluetooth/mgmt.c:2609:3: warning: symbol 'mgmt_handlers' was not declared.
> Should it be static?
> ...
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> net/bluetooth/mgmt.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
Applied. Thanks.
Johan
prev parent reply other threads:[~2012-03-16 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 8:18 [PATCH] Bluetooth: trivial: Remove sparse warnings Andrei Emeltchenko
2012-03-13 15:17 ` Marcel Holtmann
2012-03-16 15:36 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120316153630.GB21335@x220 \
--to=johan.hedberg@gmail.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).