Re: [PATCH] Bluetooth: Silence sparse warning

Marcel Holtmann
2012-03-20T15:49:36Z

Hi Andrei,

> Silence sparse warning shown below:
> ...
> net/bluetooth/mgmt.c:448:15: warning: cast to restricted __le32
> ...
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> net/bluetooth/mgmt.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index b8f9016..d93f2bf 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -443,9 +443,7 @@ static u16 get_uuid16(u8 *uuid128)
> return 0;
> }
>
> - memcpy(&val, &uuid128[12], 4);
> -
> - val = le32_to_cpu(val);
> + val = get_unaligned_le32(&uuid128[12]);

I actually prefer get_unaligned_le32(uuid128 + 12) in these cases.

Regards

Marcel