From: Johan Hedberg <johan.hedberg@gmail.com>
To: Joohi RASTOGI <joohi.rastogi@stericsson.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH Bluez V2] avcrp: Fix response length for unit info command.
Date: Tue, 27 Mar 2012 15:04:24 +0300 [thread overview]
Message-ID: <20120327120424.GL14481@x220> (raw)
In-Reply-To: <3176460F0F455A44B2E93431E34FC86C1F884A643D@EXDCVYMBSTM005.EQ1STM.local>
Hi,
On Tue, Mar 27, 2012, Joohi RASTOGI wrote:
> Hi,
>
> Fixed response length for Unit Info command. This affect PTS Test Case TC_TG_ICC_BV_01_I.
> Changed the acronym AVRCP to uppercase.
>
> From c4b1ac44ca4b608c550e8cb0b12c3b04d65aa05d Mon Sep 17 00:00:00 2001
> From: Joohi Rastogi <joohi.rastogi@stericsson.com>
> Date: Mon, 26 Mar 2012 11:53:19 +0530
> Subject: [PATCH] AVRCP: Fix response length for unit info command.
>
> ---
> audio/avctp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/audio/avctp.c b/audio/avctp.c
> index dfad9fd..5b84977 100644
> --- a/audio/avctp.c
> +++ b/audio/avctp.c
> @@ -268,7 +268,7 @@ static size_t handle_unit_info(struct avctp *session,
>
> DBG("reply to AVC_OP_UNITINFO");
>
> - return 0;
> + return operand_count;
> }
>
> static size_t handle_subunit_info(struct avctp *session,
Could you please resend both of your patches with git send-email (or if
you really are unable to use git send-email send them as attachments).
As they are right now I'm failing to pass them to "git am" from your
emails. Also, please include the references to the PTS test cases in the
commit message instead of having that somewhere external.
Johan
prev parent reply other threads:[~2012-03-27 12:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 6:44 [PATCH Bluez] avcrp: Fix response length for unit info command Joohi RASTOGI
2012-03-26 14:19 ` Luiz Augusto von Dentz
2012-03-27 10:35 ` [PATCH Bluez V2] " Joohi RASTOGI
2012-03-27 12:04 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327120424.GL14481@x220 \
--to=johan.hedberg@gmail.com \
--cc=joohi.rastogi@stericsson.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox