public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Szymon Janc <szymon.janc@tieto.com>
Cc: linux-bluetooth@vger.kernel.org, kanak.gupta@stericsson.com
Subject: Re: [PATCH V2 2/7] Set DeviceID when registering adapter not when sdp server is starting
Date: Wed, 28 Mar 2012 12:29:24 +0300	[thread overview]
Message-ID: <20120328092924.GA23691@x220> (raw)
In-Reply-To: <1332260847-20079-2-git-send-email-szymon.janc@tieto.com>

HI Szymon,

On Tue, Mar 20, 2012, Szymon Janc wrote:
> Adapter ops are registered after sdp server is started. Thus no
> adapters were registered yet when setting DID on sdp startup and DID
> was never set.
> ---
>  src/manager.c      |   15 ++++-----------
>  src/manager.h      |    1 -
>  src/sdpd-service.c |    3 ---
>  3 files changed, 4 insertions(+), 15 deletions(-)

Compilation fails with this patch:

src/manager.c: In function ‘btd_manager_register_adapter’:
src/manager.c:416:15: error: ‘struct main_opts’ has no member named ‘did’

Please fix and resend.

Johan

  reply	other threads:[~2012-03-28  9:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-20 16:27 [PATCH V2 1/7] Parse config DeviceID string on bluetoothd startup Szymon Janc
2012-03-20 16:27 ` [PATCH V2 2/7] Set DeviceID when registering adapter not when sdp server is starting Szymon Janc
2012-03-28  9:29   ` Johan Hedberg [this message]
2012-03-20 16:27 ` [PATCH V2 3/7] Add support for setting VID source in DeviceID from config file Szymon Janc
2012-03-20 16:27 ` [PATCH V2 4/7] mgmtops: Add support for setting Device ID Szymon Janc
2012-03-20 16:27 ` [PATCH V2 5/7] btmgmt: " Szymon Janc
2012-03-26 14:45   ` [PATCH V3 " Szymon Janc
2012-03-20 16:27 ` [PATCH V2 6/7] Bump Device ID service version to 1.3 Szymon Janc
2012-03-20 16:27 ` [PATCH V2 7/7] Move common code to sdp to avoid duplication Szymon Janc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120328092924.GA23691@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=kanak.gupta@stericsson.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=szymon.janc@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox