From: Gustavo Padovan <gustavo@padovan.org>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Remove unneeded zero initialization
Date: Wed, 28 Mar 2012 11:33:36 -0300 [thread overview]
Message-ID: <20120328143336.GA3962@joana> (raw)
In-Reply-To: <1332940001-20336-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
* Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com> [2012-03-28 16:06:41 +0300]:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> Remove zero initialization since channel is allocated with kzalloc
> in l2cap_chan_create.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> net/bluetooth/l2cap_sock.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
> index 53e563f..1d3e9c3 100644
> --- a/net/bluetooth/l2cap_sock.c
> +++ b/net/bluetooth/l2cap_sock.c
> @@ -1011,7 +1011,6 @@ static void l2cap_sock_init(struct sock *sk, struct sock *parent)
> chan->tx_win = L2CAP_DEFAULT_TX_WINDOW;
> chan->tx_win_max = L2CAP_DEFAULT_TX_WINDOW;
> chan->sec_level = BT_SECURITY_LOW;
> - chan->flags = 0;
> set_bit(FLAG_FORCE_ACTIVE, &chan->flags);
> }
Patch has been applied to bluetooth-next. Thanks.
Gustavo
prev parent reply other threads:[~2012-03-28 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 11:56 [PATCH] Bluetooth: Remove unneeded zero initialization Andrei Emeltchenko
2012-03-28 12:46 ` Marcel Holtmann
2012-03-28 13:06 ` Andrei Emeltchenko
2012-03-28 14:05 ` Marcel Holtmann
2012-03-28 14:33 ` Gustavo Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328143336.GA3962@joana \
--to=gustavo@padovan.org \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).