linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Clean up l2cap_chan_connect
Date: Fri, 30 Mar 2012 22:07:48 -0300	[thread overview]
Message-ID: <20120331010748.GA12922@joana> (raw)
In-Reply-To: <1333097689.1870.249.camel@aeonflux>

Hi Marcel,

* Marcel Holtmann <marcel@holtmann.org> [2012-03-30 10:54:49 +0200]:

> Hi Andrei,
> 
> > Reduce number of arguments by two and in future by another one. All
> > those parameters are passed inside L2CAP sockaddr_l2 pointer.
> 
> I am not sure that using sockaddr_l2 is a good idea. Are these socket
> address structs used directly in other parts of the networking
> subsystems anywhere?

This code was using sockaddr_l2 before, I changed it in my separate core from
sock patches. If we are separating thing we won't want to have a sock related
struct there.

	Gustavo

      parent reply	other threads:[~2012-03-31  1:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-30  7:57 [PATCH] Bluetooth: Clean up l2cap_chan_connect Andrei Emeltchenko
2012-03-30  8:54 ` Marcel Holtmann
2012-03-30 10:18   ` Andrei Emeltchenko
2012-03-31  1:07   ` Gustavo Padovan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120331010748.GA12922@joana \
    --to=gustavo@padovan.org \
    --cc=Andrei.Emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).