public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Arik Nemtsov <arik@wizery.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v6 0/6] Implement ProximityReporter profiles
Date: Mon, 2 Apr 2012 12:46:33 +0300	[thread overview]
Message-ID: <20120402094633.GA26168@x220> (raw)
In-Reply-To: <CA+XVXfcJ=zGx9Qz6tEEEoBi9F4F6jN_bgnT5+axrN3p9zRNx-A@mail.gmail.com>

Hi Arik,

On Mon, Apr 02, 2012, Arik Nemtsov wrote:
> ping?

Don't top post please.

> On Tue, Mar 27, 2012 at 22:24, Arik Nemtsov <arik@wizery.com> wrote:
> > This patch-set implements the Link loss and Immediate Alert GATT
> > server profiles.
> >
> > A few API calls are added/changed in preparation, the most notable of
> > which is the addition of the remote-device to each GATT read/write callback.
> >
> > The new profiles are separated into their own files for clarity.
> >
> > A ProximityReporter D-Bus interface is registered for each remote device.
> > Property queries and PropertyChanged notifications are implemented, in
> > accordance to doc/proximity-api.txt.
> >
> > v5->6: Fix immalert bug on unregister path. Rename att-bluez.h to
> > att-database.h. Rebase on latest master (Makefile.am changes).
> >
> > Arik Nemtsov (6):
> >  att: add remote btd_device to ATT read/write callbacks
> >  proximity: reporter: save global D-Bus connection
> >  proximity: reporter: move definitions to .h and add util function
> >  proximity: link loss: implement link loss server
> >  proximity: immediate alert: implement immediate alert server
> >  proximity: reporter: implement D-Bus API
> >
> >  Makefile.am            |    4 +-
> >  attrib/att-database.h  |   44 +++++++
> >  attrib/att.h           |   20 ---
> >  attrib/gatt-service.c  |    1 +
> >  plugins/gatt-example.c |    4 +-
> >  proximity/immalert.c   |  289 +++++++++++++++++++++++++++++++++++++++++
> >  proximity/immalert.h   |   26 ++++
> >  proximity/linkloss.c   |  337 ++++++++++++++++++++++++++++++++++++++++++++++++
> >  proximity/linkloss.h   |   26 ++++
> >  proximity/reporter.c   |  250 ++++++++++++++++++++++++++----------
> >  proximity/reporter.h   |   16 +++
> >  src/attrib-server.c    |   20 ++-
> >  time/server.c          |    7 +-
> >  13 files changed, 946 insertions(+), 98 deletions(-)
> >  create mode 100644 attrib/att-database.h
> >  create mode 100644 proximity/immalert.c
> >  create mode 100644 proximity/immalert.h
> >  create mode 100644 proximity/linkloss.c
> >  create mode 100644 proximity/linkloss.h

Firstly the patches do not apply:

Applying: att: add remote btd_device to ATT read/write callbacks
/home/jh/src/bluez/.git/rebase-apply/patch:61: new blank line at EOF.
+
fatal: 1 line adds whitespace errors.
Patch failed at 0001 att: add remote btd_device to ATT read/write callbacks

And secondly you haven't replied anything to Lizardos mail yet.

Johan

  reply	other threads:[~2012-04-02  9:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27 20:24 [PATCH v6 0/6] Implement ProximityReporter profiles Arik Nemtsov
2012-03-27 20:24 ` [PATCH v6 1/6] att: add remote btd_device to ATT read/write callbacks Arik Nemtsov
2012-03-27 20:24 ` [PATCH v6 2/6] proximity: reporter: save global D-Bus connection Arik Nemtsov
2012-03-27 20:24 ` [PATCH v6 3/6] proximity: reporter: move definitions to .h and add util function Arik Nemtsov
2012-03-27 20:24 ` [PATCH v6 4/6] proximity: link loss: implement link loss server Arik Nemtsov
2012-03-27 20:24 ` [PATCH v6 5/6] proximity: immediate alert: implement immediate alert server Arik Nemtsov
2012-03-27 20:24 ` [PATCH v6 6/6] proximity: reporter: implement D-Bus API Arik Nemtsov
2012-03-27 20:58 ` [PATCH v6 0/6] Implement ProximityReporter profiles Anderson Lizardo
2012-04-02  7:03 ` Arik Nemtsov
2012-04-02  9:46   ` Johan Hedberg [this message]
2012-04-02 11:12     ` Arik Nemtsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120402094633.GA26168@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=arik@wizery.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox