From: Johan Hedberg <johan.hedberg@gmail.com>
To: Arek Lichwa <Arkadiusz.Lichwa@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] lib: Populate response status field with rigth error code value taken from command status event.
Date: Wed, 4 Apr 2012 13:24:30 +0300 [thread overview]
Message-ID: <20120404102430.GB29893@x220> (raw)
In-Reply-To: <1331291566-8997-1-git-send-email-Arkadiusz.Lichwa@tieto.com>
Hi Arek,
On Fri, Mar 09, 2012, Arek Lichwa wrote:
> ---
> lib/hci.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/hci.c b/lib/hci.c
> index 269c021..186d408 100644
> --- a/lib/hci.c
> +++ b/lib/hci.c
> @@ -1156,6 +1156,7 @@ int hci_send_req(int dd, struct hci_request *r, int to)
>
> if (r->event != EVT_CMD_STATUS) {
> if (cs->status) {
> + memcpy(r->rparam, &cs->status, 1);
> errno = EIO;
> goto failed;
> }
I don't think we can apply this since it breaks the way that the library
function works (guaranteeing that rparam isn't touched if the function
returns an error).
Johan
prev parent reply other threads:[~2012-04-04 10:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 11:12 [PATCH BlueZ] lib: Populate response status field with rigth error code value taken from command status event Arek Lichwa
2012-04-04 10:24 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404102430.GB29893@x220 \
--to=johan.hedberg@gmail.com \
--cc=Arkadiusz.Lichwa@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox