linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: Don't set Discoverty Type while stopping Discovery
@ 2012-04-05  4:57 Hemant Gupta
  2012-04-05 10:54 ` Johan Hedberg
  0 siblings, 1 reply; 2+ messages in thread
From: Hemant Gupta @ 2012-04-05  4:57 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Hemant Gupta, Hemant Gupta

This patch prevents resetting of discovery type while stopping
discovery, which was sending wrong type information to management
interface of BlueZ when discovery failed.

Signed-off-by: Hemant Gupta <hemant.gupta@stericsson.com>
---
 net/bluetooth/hci_core.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 286f3fc..9629645 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -386,7 +386,6 @@ void hci_discovery_set_state(struct hci_dev *hdev, int state)
 	case DISCOVERY_STOPPED:
 		if (hdev->discovery.state != DISCOVERY_STARTING)
 			mgmt_discovering(hdev, 0);
-		hdev->discovery.type = 0;
 		break;
 	case DISCOVERY_STARTING:
 		break;
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Bluetooth: Don't set Discoverty Type while stopping Discovery
  2012-04-05  4:57 [PATCH] Bluetooth: Don't set Discoverty Type while stopping Discovery Hemant Gupta
@ 2012-04-05 10:54 ` Johan Hedberg
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2012-04-05 10:54 UTC (permalink / raw)
  To: Hemant Gupta; +Cc: linux-bluetooth, Hemant Gupta

Hi Hemant,

On Thu, Apr 05, 2012, Hemant Gupta wrote:
> This patch prevents resetting of discovery type while stopping
> discovery, which was sending wrong type information to management
> interface of BlueZ when discovery failed.
> 
> Signed-off-by: Hemant Gupta <hemant.gupta@stericsson.com>
> ---
>  net/bluetooth/hci_core.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

Applied to bluetooth-next, but you really need to start using a spell
checker on your commit messages. Also, you don't necessarily need to
refer to the behavior caused to current user space since it's perfectly
possible to justify the patch without that. Furthermore, please prefix
any fixes with "Fix ...". It makes it easier to get these pulled once
applied to bluetooth.git (less explaining to do to the wireless
maintainer).

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-04-05 10:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-05  4:57 [PATCH] Bluetooth: Don't set Discoverty Type while stopping Discovery Hemant Gupta
2012-04-05 10:54 ` Johan Hedberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).