From: Johan Hedberg <johan.hedberg@gmail.com>
To: Slawomir Bochenski <lkslawek@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd 1/3] MAP: Mark filter strings const
Date: Tue, 10 Apr 2012 11:28:20 +0300 [thread overview]
Message-ID: <20120410082820.GA5354@x220> (raw)
In-Reply-To: <1334005380-31302-1-git-send-email-lkslawek@gmail.com>
Hi Slawek,
On Mon, Apr 09, 2012, Slawomir Bochenski wrote:
> ---
> plugins/messages.h | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
It would be good if you could get into the habit of writing proper
commit messages. One-liners are only acceptable for extremely trivial
patches and even then I wont complain if they come with more verbose
messages.
E.g. in this case I'd at a minimum be expecting something like "These
variables should be marked as const because ...". Same goes for the rest
of the patches in this set. As far as the code changes are concerned I
didn't see anything obvious that needs fixing.
Johan
prev parent reply other threads:[~2012-04-10 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 21:02 [PATCH obexd 1/3] MAP: Mark filter strings const Slawomir Bochenski
2012-04-09 21:02 ` [PATCH obexd 2/3] MAP: Input parameters for GetMessagesListing Slawomir Bochenski
2012-04-09 21:03 ` [PATCH obexd 3/3] MAP: Output " Slawomir Bochenski
2012-04-10 8:28 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410082820.GA5354@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lkslawek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox