linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Michal Labedzki <michal.labedzki@tieto.com>
Cc: linux-bluetooth@vger.kernel.org, luiz.dentz@gmail.com,
	lucas.demarchi@profusion.mobi
Subject: Re: [PATCH v2 1/3] AVRCP: Add missing capability for TrackReachedEnd
Date: Thu, 12 Apr 2012 14:47:21 +0300	[thread overview]
Message-ID: <20120412114721.GA20659@x220.ger.corp.intel.com> (raw)
In-Reply-To: <1334142318-24916-1-git-send-email-michal.labedzki@tieto.com>

Hi Michal,

On Wed, Apr 11, 2012, Michal Labedzki wrote:
> Add missing capability for TrackReachedEnd.
> ---
>  audio/avrcp.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/audio/avrcp.c b/audio/avrcp.c
> index 8eba046..6eb4bb1 100644
> --- a/audio/avrcp.c
> +++ b/audio/avrcp.c
> @@ -557,12 +557,13 @@ static uint8_t avrcp_handle_get_capabilities(struct avrcp_player *player,
>  
>  		return AVC_CTYPE_STABLE;
>  	case CAP_EVENTS_SUPPORTED:
> -		pdu->params_len = htons(5);
> -		pdu->params[1] = 3;
> +		pdu->params[1] = 4;
>  		pdu->params[2] = AVRCP_EVENT_STATUS_CHANGED;
>  		pdu->params[3] = AVRCP_EVENT_TRACK_CHANGED;
>  		pdu->params[4] = AVRCP_EVENT_TRACK_REACHED_START;
> +		pdu->params[5] = AVRCP_EVENT_TRACK_REACHED_END;
>  
> +		pdu->params_len = htons(2 + pdu->params[1]);
>  		return AVC_CTYPE_STABLE;
>  	}

This patch has been applied. Thanks.

Johan

  parent reply	other threads:[~2012-04-12 11:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11  9:12 [PATCH v2 3/3] AVRCP: Add support to changing active player Michal Labedzki
2012-04-11  9:12 ` [PATCH 1/3] AVRCP: Add missing capability for TrackReachedEnd Michal Labedzki
2012-04-11 10:48   ` Luiz Augusto von Dentz
2012-04-11 11:05     ` [PATCH v2 " Michal Labedzki
2012-04-11 11:12       ` Luiz Augusto von Dentz
2012-04-12 11:47       ` Johan Hedberg [this message]
2012-04-11  9:12 ` [PATCH 2/3] AVRCP: Remove unused field in player structure Michal Labedzki
2012-04-11 11:14   ` Luiz Augusto von Dentz
2012-04-11  9:12 ` [PATCH v2 3/3] AVRCP: Add support to changing active player Michal Labedzki
2012-04-11 11:10   ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120412114721.GA20659@x220.ger.corp.intel.com \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=luiz.dentz@gmail.com \
    --cc=michal.labedzki@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).