From: Johan Hedberg <johan.hedberg@gmail.com>
To: Hemant Gupta <hemant.gupta@stericsson.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] Store LE device address type with primary list
Date: Thu, 26 Apr 2012 12:32:03 +0300 [thread overview]
Message-ID: <20120426093203.GB18380@x220> (raw)
In-Reply-To: <1335360420-23445-1-git-send-email-hemant.gupta@stericsson.com>
Hi Hemant,
On Wed, Apr 25, 2012, Hemant Gupta wrote:
> This patch stores the address type while storing the primary services
> of LE Device which is later used for re-creating device from primary
> service database.
> ---
> src/adapter.c | 10 ++++++++--
> src/device.c | 9 +++++++--
> 2 files changed, 15 insertions(+), 4 deletions(-)
Would it make more sense (and I'm not asking just you but also the
INdTers) to have the address type as part of the key instead of the
value. After all it's basically an extension to the address and that way
tightly bound to it. Maybe something like the following:
11:22:33:44:55:66|1 <value1>
aa:bb:cc:dd:ee:ff|0 <value2>
The same should then also be considered for the longtermkeys file.
Johan
next prev parent reply other threads:[~2012-04-26 9:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 13:27 [PATCH v2] Store LE device address type with primary list Hemant Gupta
2012-04-26 9:32 ` Johan Hedberg [this message]
2012-04-26 21:02 ` Claudio Takahasi
2012-04-27 12:15 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120426093203.GB18380@x220 \
--to=johan.hedberg@gmail.com \
--cc=hemant.gupta@stericsson.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox