Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Vishal Agarwal <vishal.agarwal@stericsson.com>,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Padding should be removed from EIR data
Date: Thu, 26 Apr 2012 14:49:49 +0300	[thread overview]
Message-ID: <20120426114949.GA3261@x220.ger.corp.intel.com> (raw)
In-Reply-To: <20120426105717.GA1573@x220>

Hi Vishal,

On Thu, Apr 26, 2012, Johan Hedberg wrote:
> > +static inline size_t eir_get_padding_offset(u8 *eir, size_t eir_len)
> 
> I'm not completely sure about this name. Would eir_significant_len()
> sound better? The core spec uses the terminology "significant part" and
> non-significant part" to refer to this so I thought reusing that might
> make it clearer what we're dealing with.

I changed my mind: let's just call it eir_get_length(). And to make it
more clear call the input parameters data and data_len.

Johan

      reply	other threads:[~2012-04-26 11:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-25 13:27 [PATCH] Bluetooth: Padding should be removed from EIR data Vishal Agarwal
2012-04-26 10:57 ` Johan Hedberg
2012-04-26 11:49   ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120426114949.GA3261@x220.ger.corp.intel.com \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=vishal.agarwal@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox