From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-bluetooth@vger.kernel.org
Subject: Re: [now bisected] Weird bluetooth keyboard regression - just me?
Date: Tue, 1 May 2012 18:19:01 +0100 [thread overview]
Message-ID: <20120501171901.GA26006@srcf.ucam.org> (raw)
In-Reply-To: <20120501110156.2b6e0561@lwn.net>
On Tue, May 01, 2012 at 11:01:56AM -0600, Jonathan Corbet wrote:
> OK, git bisect has rendered its verdict:
>
> d35e70d50a0641ebc1502fd343bef9b4011ada27 is the first bad commit
> commit d35e70d50a0641ebc1502fd343bef9b4011ada27
> Author: Matthew Garrett <mjg@redhat.com>
> Date: Fri Feb 3 17:11:55 2012 -0500
>
> usb: Use hub port data to determine whether a port is removable
>
> Hubs have a flag to indicate whether a given port carries removable devices
> or not. This is not strictly accurate in that some built-in devices
> will be flagged as removable, but followup patches will make use of platform
> data to make this more reliable.
>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ...and, indeed, things do seem to break right there.
>
> I assume there's something funky about the (oldish) USB bluetooth dongle
> that came with my keyboard that interacts badly with this patch. Matthew,
> is there anything I can do or tell you to help figure this one out?
On its own, this should do precisely nothing. What userspace are you
running, and what does the removable node in the sysfs entry for the
dongle's USB device say?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-05-01 17:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 13:37 Weird bluetooth keyboard regression - just me? Jonathan Corbet
2012-05-01 16:00 ` Gustavo Padovan
2012-05-01 17:01 ` [now bisected] " Jonathan Corbet
2012-05-01 17:19 ` Matthew Garrett [this message]
2012-05-01 18:01 ` Jonathan Corbet
2012-05-01 18:31 ` Matthew Garrett
2012-05-01 18:39 ` Jonathan Corbet
2012-05-01 18:54 ` Matthew Garrett
2012-05-01 19:27 ` Matthew Garrett
2012-05-01 23:24 ` Jonathan Corbet
2012-05-02 21:50 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120501171901.GA26006@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=corbet@lwn.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).