* [PATCH BlueZ] mgmtops: Fix wrong parameter order for btd_event_ltk_notify()
@ 2012-04-27 14:57 Anderson Lizardo
2012-05-02 11:53 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: Anderson Lizardo @ 2012-04-27 14:57 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Anderson Lizardo
The "master" parameter was in the wrong place.
---
plugins/mgmtops.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
To those interested, this was not noticed before because:
* We don't use the stored information yet (although we will probably use soon
the "authenticated" field for ATT requests that return "Insufficient
Authentication")
* The storage types for master/authenticated/enc_size are compatible.
diff --git a/plugins/mgmtops.c b/plugins/mgmtops.c
index ddd544d..22fa329 100644
--- a/plugins/mgmtops.c
+++ b/plugins/mgmtops.c
@@ -1694,9 +1694,9 @@ static void mgmt_new_ltk(int sk, uint16_t index, void *buf, size_t len)
if (ev->store_hint) {
btd_event_ltk_notify(&info->bdaddr, &ev->key.addr.bdaddr,
- ev->key.addr.type, ev->key.val,
+ ev->key.addr.type, ev->key.val, ev->key.master,
ev->key.authenticated, ev->key.enc_size,
- ev->key.master, ev->key.ediv, ev->key.rand);
+ ev->key.ediv, ev->key.rand);
}
if (ev->key.master)
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH BlueZ] mgmtops: Fix wrong parameter order for btd_event_ltk_notify()
2012-04-27 14:57 [PATCH BlueZ] mgmtops: Fix wrong parameter order for btd_event_ltk_notify() Anderson Lizardo
@ 2012-05-02 11:53 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2012-05-02 11:53 UTC (permalink / raw)
To: Anderson Lizardo; +Cc: linux-bluetooth
Hi Lizardo,
On Fri, Apr 27, 2012, Anderson Lizardo wrote:
> The "master" parameter was in the wrong place.
> ---
> plugins/mgmtops.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> To those interested, this was not noticed before because:
>
> * We don't use the stored information yet (although we will probably use soon
> the "authenticated" field for ATT requests that return "Insufficient
> Authentication")
> * The storage types for master/authenticated/enc_size are compatible.
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-02 11:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-27 14:57 [PATCH BlueZ] mgmtops: Fix wrong parameter order for btd_event_ltk_notify() Anderson Lizardo
2012-05-02 11:53 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).