From: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
To: Syam Sidhardhan <s.syam@samsung.com>
Cc: Andre Guedes <andre.guedes@openbossa.org>,
Gustavo Padovan <gustavo@padovan.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/5] Bluetooth: Remove unused hci_le_ltk_reply()
Date: Wed, 2 May 2012 11:38:05 -0300 [thread overview]
Message-ID: <20120502143805.GA4019@samus> (raw)
In-Reply-To: <689E6E1F4998496D92F8631D325F12A3@sisodomain.com>
Hi Syam and Johan,
On 21:18 Tue 01 May, Syam Sidhardhan wrote:
> Hi,
> ----- Original Message ----- From: "Andre Guedes"
> <andre.guedes@openbossa.org>
> To: "Gustavo Padovan" <gustavo@padovan.org>; "Syam Sidhardhan"
> <s.syam@samsung.com>; <linux-bluetooth@vger.kernel.org>; "Vinicius
> Gomes" <vinicius.gomes@openbossa.org>
> Sent: Friday, April 20, 2012 11:43 PM
> Subject: Re: [PATCH 1/5] Bluetooth: Remove unused hci_le_ltk_reply()
>
>
> >Hi Syam/Gustavo,
> >
> >On Fri, Apr 13, 2012 at 7:17 PM, Gustavo Padovan
> ><gustavo@padovan.org> wrote:
> >>Hi Syam,
> >>
> >>* Syam Sidhardhan <s.syam@samsung.com> [2012-04-12 20:33:17 +0530]:
> >>
> >>>In this API, we were using sizeof operator for an array
> >>>given as function argument, which is invalid.
> >>>However this API is not used anywhere.
> >>>
> >>>Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
> >>>---
> >>>include/net/bluetooth/hci_core.h | 1 -
> >>>net/bluetooth/hci_conn.c | 16 ----------------
> >>>2 files changed, 0 insertions(+), 17 deletions(-)
> >>>
> >>>diff --git a/include/net/bluetooth/hci_core.h
> >>>b/include/net/bluetooth/hci_core.h
> >>>index c0b232c..6e170de 100644
> >>>--- a/include/net/bluetooth/hci_core.h
> >>>+++ b/include/net/bluetooth/hci_core.h
> >>>@@ -1069,7 +1069,6 @@ void hci_le_conn_update(struct hci_conn
> >>>*conn, u16 min, u16 max,
> >>>u16 latency, u16 to_multiplier);
> >>>void hci_le_start_enc(struct hci_conn *conn, __le16 ediv, __u8 rand[8],
> >>>__u8 ltk[16]);
> >>>-void hci_le_ltk_reply(struct hci_conn *conn, u8 ltk[16]);
> >>
> >>I'll let Andre comment here, I'm not sure if this is going to be used on
> >>the future or not.
> >
> >I'm not sure too, I think Vinicius can tell more about that.
Just in case you missed what I just said on IRC: that function can be
removed.
> >
> >Regarding the memcpy call, yes, it is definitely bogus.
> >
>
> ping
>
> Regards,
> Syam
>
Cheers,
--
Vinicius
next prev parent reply other threads:[~2012-05-02 14:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 15:02 [PATCH BlueZ 00/19] Fix D-Bus memory leaks, bluetooth name, double unref etc Syam Sidhardhan
2012-04-12 15:02 ` [PATCH BlueZ 01/19] health: Fix memory leak Syam Sidhardhan
2012-04-12 15:02 ` [PATCH BlueZ 02/19] avrcp: Fix the response ctype of SetPlayerApplicationSettingValue Syam Sidhardhan
2012-04-12 20:30 ` Lucas De Marchi
2012-04-12 15:02 ` [PATCH BlueZ 03/19] agent: Free the agent request properly Syam Sidhardhan
2012-04-12 15:02 ` [PATCH BlueZ 04/19] gstavdtpsink: Fix D-Bus memory leak in audio Syam Sidhardhan
2012-04-12 15:02 ` [PATCH BlueZ 05/19] gateway: " Syam Sidhardhan
2012-04-12 15:02 ` [PATCH BlueZ 06/19] gateway: Fix D-Bus reply memory leak Syam Sidhardhan
2012-04-12 15:02 ` [PATCH BlueZ 07/19] hci: Retrieve the bluetooth name correctly Syam Sidhardhan
2012-04-13 9:51 ` Johan Hedberg
2012-04-12 15:02 ` [PATCH BlueZ 08/19] hciconfig: Remove unwanted NULL termination Syam Sidhardhan
2012-04-12 15:03 ` [PATCH BlueZ 09/19] agent: Fix double D-Bus message unref Syam Sidhardhan
2012-04-12 15:03 ` [PATCH BlueZ 10/19] sdpd-request: Fix passing zero instead of NULL Syam Sidhardhan
2012-04-12 15:03 ` [PATCH BlueZ 11/19] sap-u8500: Fix empty parameter list in function declaration Syam Sidhardhan
2012-04-12 15:03 ` [PATCH BlueZ 12/19] adapter: Remove headers declared but not defined Syam Sidhardhan
2012-04-12 15:03 ` [PATCH BlueZ 13/19] headset: Remove header " Syam Sidhardhan
2012-04-12 15:03 ` [PATCH BlueZ 14/19] network: " Syam Sidhardhan
2012-04-12 15:03 ` [PATCH BlueZ 15/19] audio: Fix newline before EOF Syam Sidhardhan
2012-04-12 15:03 ` [PATCH BlueZ 16/19] input: " Syam Sidhardhan
2012-04-12 15:03 ` [PATCH BlueZ 17/19] src: " Syam Sidhardhan
2012-04-12 15:03 ` [PATCH BlueZ 18/19] doc: Fix typo Syam Sidhardhan
2012-04-12 15:03 ` [PATCH BlueZ 19/19] Add Syam's email address Syam Sidhardhan
2012-04-12 15:03 ` [PATCH obexd 0/4] Fix memory leak, remove unused struct etc Syam Sidhardhan
2012-04-13 10:08 ` Johan Hedberg
2012-04-12 15:03 ` [PATCH obexd 1/4] client: Fix memory leak during session connect Syam Sidhardhan
2012-04-12 15:03 ` [PATCH obexd 2/4] src: Use goto for avoiding code duplication Syam Sidhardhan
2012-04-12 15:03 ` [PATCH obexd 3/4] src: Remove headers declared but not defined Syam Sidhardhan
2012-04-12 15:03 ` [PATCH obexd 4/4] client: Remove unused struct session_callback Syam Sidhardhan
2012-04-12 15:03 ` [PATCH 0/5] Bluetooth: Remove unused API's and code optimization Syam Sidhardhan
2012-04-13 22:24 ` Gustavo Padovan
2012-04-12 15:03 ` [PATCH 1/5] Bluetooth: Remove unused hci_le_ltk_reply() Syam Sidhardhan
2012-04-13 22:17 ` Gustavo Padovan
2012-04-20 18:13 ` Andre Guedes
2012-05-01 15:48 ` Syam Sidhardhan
2012-05-02 14:38 ` Vinicius Costa Gomes [this message]
2012-05-02 14:58 ` Gustavo Padovan
2012-05-03 5:57 ` Syam Sidhardhan
2012-04-12 15:03 ` [PATCH 2/5] Bluetooth: Remove unused hci_le_ltk_neg_reply() Syam Sidhardhan
2012-04-12 15:03 ` [PATCH 3/5] Bluetooth: hci_core: Remove header declared but not define Syam Sidhardhan
2012-04-13 22:21 ` Gustavo Padovan
2012-04-12 15:03 ` [PATCH 4/5] Bluetooth: Remove strtoba " Syam Sidhardhan
2012-04-13 22:27 ` Gustavo Padovan
2012-04-12 15:03 ` [PATCH 5/5] Bluetooth: mgmt: Remove unwanted goto statement Syam Sidhardhan
2012-04-14 16:29 ` Johan Hedberg
2012-04-13 9:47 ` [PATCH BlueZ 00/19] Fix D-Bus memory leaks, bluetooth name, double unref etc Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502143805.GA4019@samus \
--to=vinicius.gomes@openbossa.org \
--cc=andre.guedes@openbossa.org \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=s.syam@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).