Re: [PATCH] Bluetooth: Remove unneeded calculation and magic number

[Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>]

Hi,

On Thu, May 03, 2012 at 10:55:52AM +0300, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> 
> Remove magic number unneeded calculation since
> hlen = L2CAP_HDR_SIZE + L2CAP_PSMLEN_SIZE

Since Gustavo removed hlen I'll do the same.

Best regards 
Andrei Emeltchenko 

> 
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
>  net/bluetooth/l2cap_core.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index 07a09cc..1748c3c 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -1922,8 +1922,8 @@ static struct sk_buff *l2cap_create_connless_pdu(struct l2cap_chan *chan,
>  	/* Create L2CAP header */
>  	lh = (struct l2cap_hdr *) skb_put(skb, L2CAP_HDR_SIZE);
>  	lh->cid = cpu_to_le16(chan->dcid);
> -	lh->len = cpu_to_le16(len + (hlen - L2CAP_HDR_SIZE));
> -	put_unaligned(chan->psm, skb_put(skb, 2));
> +	lh->len = cpu_to_le16(len + L2CAP_PSMLEN_SIZE);
> +	put_unaligned(chan->psm, skb_put(skb, L2CAP_PSMLEN_SIZE));
>  
>  	err = l2cap_skbuff_fromiovec(chan, msg, len, count, skb);
>  	if (unlikely(err < 0)) {
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html