From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: David Herrmann <dh.herrmann@googlemail.com>,
linux-bluetooth@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: batostr() function
Date: Tue, 8 May 2012 17:30:12 +0300 [thread overview]
Message-ID: <20120508143011.GD29352@aemeltch-MOBL1> (raw)
In-Reply-To: <1336487108.4320.2.camel@jlt3.sipsolutions.net>
On Tue, May 08, 2012 at 04:25:08PM +0200, Johannes Berg wrote:
> On Tue, 2012-05-08 at 15:30 +0200, David Herrmann wrote:
> > Hi Johannes
> >
> > On Mon, May 7, 2012 at 1:49 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > > Really? 2 static buffers that are used alternately based on a static
> > > variable? How can that possibly be thread-safe? That may work in very
> > > restricted scenarios, but ...
> >
> > Looking at "git blame" it seems the whole function is still from
> > linux-2.4. Looks like no-one ever noticed. I've sent a patchset fixing
> > it, thanks.
>
> I was thinking you could use %pM, but it seems BT addresses are stored
> the wrong way around for some reason ...
This looks like better idea then allocating buffers, we can use swap to
take care about "wrong order".
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2012-05-08 14:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 11:49 batostr() function Johannes Berg
2012-05-08 13:30 ` David Herrmann
2012-05-08 14:20 ` Ulisses Furquim
2012-05-08 14:25 ` Johannes Berg
2012-05-08 14:30 ` Andrei Emeltchenko [this message]
2012-05-08 17:18 ` Joe Perches
2012-05-08 17:48 ` Johannes Berg
2012-05-08 18:26 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508143011.GD29352@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=dh.herrmann@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).