From: Gustavo Padovan <gustavo@padovan.org>
To: Cristian Chilipirea <cristian.chilipirea@gmail.com>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
linux-bluetooth@vger.kernel.org, daniel.baluta@gmail.com
Subject: Re: [PATCH] bluetooth: Fixed checkpatch warnings
Date: Wed, 9 May 2012 03:09:12 -0300 [thread overview]
Message-ID: <20120509060912.GE2362@joana> (raw)
In-Reply-To: <1336542292-15258-1-git-send-email-cristian.chilipirea@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1422 bytes --]
Hi Cristian,
* Cristian Chilipirea <cristian.chilipirea@gmail.com> [2012-05-09 08:44:52 +0300]:
> Fixed some checkpatch warnings in mgmt.c.
>
> Signed-off-by: Cristian Chilipirea <cristian.chilipirea@gmail.com>
> ---
> net/bluetooth/mgmt.c | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
> mode change 100644 => 100755 net/bluetooth/mgmt.c
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> old mode 100644
> new mode 100644
> index 4bb03b1..494004d
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -1122,8 +1122,8 @@ static int set_ssp(struct sock *sk, struct hci_dev *hdev, void *data, u16 len)
> }
>
> if (mgmt_pending_find(MGMT_OP_SET_SSP, hdev)) {
> - err = cmd_status(sk, hdev->id, MGMT_OP_SET_SSP,
> - MGMT_STATUS_BUSY);
> + err = cmd_status(sk, hdev->id, MGMT_OP_SET_SSP,
> + MGMT_STATUS_BUSY);
> goto failed;
> }
>
> @@ -2884,7 +2884,8 @@ int mgmt_write_scan_failed(struct hci_dev *hdev, u8 scan, u8 status)
> return 0;
> }
>
> -int mgmt_new_link_key(struct hci_dev *hdev, struct link_key *key, bool persistent)
> +int mgmt_new_link_key(struct hci_dev *hdev, struct link_key *key,
> + bool persistent)
It turns out that all your proposed fixes but this were already fixed in
bluetooth-next. I went ahead and applied only this one, patch is now upstream.
Thanks.
Gustavo
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-05-09 6:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 5:44 [PATCH] bluetooth: Fixed checkpatch warnings Cristian Chilipirea
2012-05-09 6:09 ` Gustavo Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120509060912.GE2362@joana \
--to=gustavo@padovan.org \
--cc=cristian.chilipirea@gmail.com \
--cc=daniel.baluta@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).