From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
To: <joohi.rastogi@stericsson.com>
Cc: User Name <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 2/2] AVRCP: Add missing Player Setting feature in TG record
Date: Thu, 10 May 2012 12:48:28 -0300 [thread overview]
Message-ID: <20120510124828.79c6ffa7@vader> (raw)
In-Reply-To: <1336631264-27977-1-git-send-email-joohi.rastogi@stericsson.com>
On Thu, 10 May 2012 11:57:44 +0530
<joohi.rastogi@stericsson.com> wrote:
> From: Joohi Rastogi <joohi.rastogi@stericsson.com>
>
> ---
> audio/avrcp.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/audio/avrcp.c b/audio/avrcp.c
> index 1b35c3f..7ed1bbb 100644
> --- a/audio/avrcp.c
> +++ b/audio/avrcp.c
> @@ -93,6 +93,7 @@
> #define AVRCP_FEATURE_CATEGORY_2 0x0002
> #define AVRCP_FEATURE_CATEGORY_3 0x0004
> #define AVRCP_FEATURE_CATEGORY_4 0x0008
> +#define AVRCP_FEATURE_PLAYER_SETTINGS 0x0010
>
> enum battery_status {
> BATTERY_STATUS_NORMAL = 0,
> @@ -247,7 +248,8 @@ static sdp_record_t *avrcp_tg_record(void)
> uint16_t lp = AVCTP_PSM;
> uint16_t avrcp_ver = 0x0103, avctp_ver = 0x0103;
> uint16_t feat = (AVRCP_FEATURE_CATEGORY_1 |
> AVRCP_FEATURE_CATEGORY_2
> - | AVRCP_FEATURE_CATEGORY_3 |
> AVRCP_FEATURE_CATEGORY_4);
> + | AVRCP_FEATURE_CATEGORY_3 | AVRCP_FEATURE_CATEGORY_4
> + | AVRCP_FEATURE_PLAYER_SETTINGS);
Ack, but I'm not sure about the coding style. I think the preferred way
to split lines is to put "|" in the line before (and indent past the
"(".
Lucas De Marchi
next prev parent reply other threads:[~2012-05-10 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 6:27 [PATCH 2/2] AVRCP: Add missing Player Setting feature in TG record joohi.rastogi
2012-05-10 15:48 ` Lucas De Marchi [this message]
[not found] ` <20120510124743.339acb16@vader>
2012-05-10 15:52 ` Lucas De Marchi
-- strict thread matches above, loose matches on Subject: below --
2012-05-18 5:39 joohi.rastogi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120510124828.79c6ffa7@vader \
--to=lucas.demarchi@profusion.mobi \
--cc=joohi.rastogi@stericsson.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox