[PATCH BlueZ 0/9] Fix indentation and tab misuse

[PATCH BlueZ 0/9] Fix indentation and tab misuse

[Anderson Lizardo]

Hi,

These are minor style fixes found "semi-automatically" while reviewing code.

Best Regards,

Anderson Lizardo (9):
  lib: Fix tab misuse
  tools: Fix tab misuse
  event: Fix tab misuse
  device: Fix tab misuse
  sap: Fix tab misuse
  monitor: Fix tab misuse
  deviceinfo: Fix indentation and tab misuse
  audio: Fix tab misuse
  hidd: Fix indentation

 audio/pcm_bluetooth.c   |    2 +-
 compat/hidd.c           |    2 +-
 deviceinfo/deviceinfo.c |    4 ++--
 lib/hci.c               |    2 +-
 lib/hci_lib.h           |    2 +-
 monitor/packet.c        |    2 +-
 sap/server.c            |    2 +-
 src/device.c            |    2 +-
 src/event.c             |    2 +-
 src/event.h             |    2 +-
 tools/hciattach_ath3k.c |    2 +-
 tools/sdptool.c         |    2 +-
 12 files changed, 13 insertions(+), 13 deletions(-)

-- 
1.7.5.4

[PATCH BlueZ 1/9] lib: Fix tab misuse

[Anderson Lizardo]

---
 lib/hci.c     |    2 +-
 lib/hci_lib.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/hci.c b/lib/hci.c
index 269c021..66b2d5f 100644
--- a/lib/hci.c
+++ b/lib/hci.c
@@ -2829,7 +2829,7 @@ int hci_le_set_advertise_enable(int dd, uint8_t enable, int to)
 int hci_le_create_conn(int dd, uint16_t interval, uint16_t window,
 		uint8_t initiator_filter, uint8_t peer_bdaddr_type,
 		bdaddr_t peer_bdaddr, uint8_t own_bdaddr_type,
-		uint16_t min_interval, 	uint16_t max_interval,
+		uint16_t min_interval, uint16_t max_interval,
 		uint16_t latency, uint16_t supervision_timeout,
 		uint16_t min_ce_length, uint16_t max_ce_length,
 		uint16_t *handle, int to)
diff --git a/lib/hci_lib.h b/lib/hci_lib.h
index 725eb05..cf4a0ff 100644
--- a/lib/hci_lib.h
+++ b/lib/hci_lib.h
@@ -123,7 +123,7 @@ int hci_le_set_advertise_enable(int dev_id, uint8_t enable, int to);
 int hci_le_create_conn(int dd, uint16_t interval, uint16_t window,
 		uint8_t initiator_filter, uint8_t peer_bdaddr_type,
 		bdaddr_t peer_bdaddr, uint8_t own_bdaddr_type,
-		uint16_t min_interval, 	uint16_t max_interval,
+		uint16_t min_interval, uint16_t max_interval,
 		uint16_t latency, uint16_t supervision_timeout,
 		uint16_t min_ce_length, uint16_t max_ce_length,
 		uint16_t *handle, int to);
-- 
1.7.5.4

[PATCH BlueZ 2/9] tools: Fix tab misuse

[Anderson Lizardo]

---
 tools/hciattach_ath3k.c |    2 +-
 tools/sdptool.c         |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/hciattach_ath3k.c b/tools/hciattach_ath3k.c
index 803cf46..23208c6 100644
--- a/tools/hciattach_ath3k.c
+++ b/tools/hciattach_ath3k.c
@@ -900,7 +900,7 @@ int ath3k_post(int fd, int pm)
 	}
 
 	/* send vendor specific command with Sleep feature Enabled */
-	if (hci_send_cmd(dd, OGF_VENDOR_CMD, HCI_SLEEP_CMD_OCF,	1, &pm) < 0)
+	if (hci_send_cmd(dd, OGF_VENDOR_CMD, HCI_SLEEP_CMD_OCF, 1, &pm) < 0)
 		perror("PM command failed, power management Disabled");
 
 	nanosleep(&tm, NULL);
diff --git a/tools/sdptool.c b/tools/sdptool.c
index db9ac0d..4e9da64 100644
--- a/tools/sdptool.c
+++ b/tools/sdptool.c
@@ -3468,7 +3468,7 @@ static int add_gatt(sdp_session_t *session, svc_info_t *si)
 
 	ret = sdp_device_record_register(session, &interface, &record,
 							SDP_RECORD_PERSIST);
-	if (ret	< 0)
+	if (ret < 0)
 		printf("Service Record registration failed\n");
 	else
 		printf("Generic Attribute Profile Service registered\n");
-- 
1.7.5.4

[PATCH BlueZ 3/9] event: Fix tab misuse

[Anderson Lizardo]

---
 src/event.c |    2 +-
 src/event.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/event.c b/src/event.c
index f576102..514744b 100644
--- a/src/event.c
+++ b/src/event.c
@@ -430,7 +430,7 @@ int btd_event_link_key_notify(bdaddr_t *local, bdaddr_t *peer,
 int btd_event_ltk_notify(bdaddr_t *local, bdaddr_t *peer, uint8_t bdaddr_type,
 					uint8_t *key, uint8_t master,
 					uint8_t authenticated, uint8_t enc_size,
-					uint16_t ediv, 	uint8_t rand[8])
+					uint16_t ediv, uint8_t rand[8])
 {
 	struct btd_adapter *adapter;
 	struct btd_device *device;
diff --git a/src/event.h b/src/event.h
index c4ae18f..dfc158d 100644
--- a/src/event.h
+++ b/src/event.h
@@ -46,4 +46,4 @@ int btd_event_link_key_notify(bdaddr_t *local, bdaddr_t *peer, uint8_t *key,
 int btd_event_ltk_notify(bdaddr_t *local, bdaddr_t *peer, uint8_t bdaddr_type,
 					uint8_t *key, uint8_t master,
 					uint8_t authenticated, uint8_t enc_size,
-					uint16_t ediv, 	uint8_t rand[8]);
+					uint16_t ediv, uint8_t rand[8]);
-- 
1.7.5.4

[PATCH BlueZ 4/9] device: Fix tab misuse

[Anderson Lizardo]

---
 src/device.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/device.c b/src/device.c
index 021b200..2a8812e 100644
--- a/src/device.c
+++ b/src/device.c
@@ -1005,7 +1005,7 @@ static void device_set_vendor_src(struct btd_device *device, uint16_t value)
 	device->vendor_src = value;
 
 	emit_property_changed(conn, device->path, DEVICE_INTERFACE,
-				"VendorSource",	DBUS_TYPE_UINT16, &value);
+				"VendorSource", DBUS_TYPE_UINT16, &value);
 }
 
 static void device_set_product(struct btd_device *device, uint16_t value)
-- 
1.7.5.4

[PATCH BlueZ 5/9] sap: Fix tab misuse

[Anderson Lizardo]

---
 sap/server.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sap/server.c b/sap/server.c
index eaf9d86..945d599 100644
--- a/sap/server.c
+++ b/sap/server.c
@@ -1265,7 +1265,7 @@ static DBusMessage *disconnect(DBusConnection *conn, DBusMessage *msg,
 		return message_failed(msg, "Client already disconnected");
 
 	if (disconnect_req(server->conn, SAP_DISCONNECTION_TYPE_GRACEFUL) < 0)
-		return g_dbus_create_error(msg, ERROR_INTERFACE	".Failed",
+		return g_dbus_create_error(msg, ERROR_INTERFACE ".Failed",
 					"There is no active connection");
 
 	return dbus_message_new_method_return(msg);
-- 
1.7.5.4

[PATCH BlueZ 6/9] monitor: Fix tab misuse

[Anderson Lizardo]

---
 monitor/packet.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 356e0a3..0f14ea6 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -654,7 +654,7 @@ void packet_hci_scodata(struct timeval *tv, uint16_t index, bool in,
 	}
 
 	printf("%c SCO Data: handle %d flags 0x%2.2x dlen %d\n",
-			in ? '>' : '<',	acl_handle(handle), flags, hdr->dlen);
+			in ? '>' : '<', acl_handle(handle), flags, hdr->dlen);
 
 	data += HCI_SCO_HDR_SIZE;
 	size -= HCI_SCO_HDR_SIZE;
-- 
1.7.5.4

[PATCH BlueZ 7/9] deviceinfo: Fix indentation and tab misuse

[Anderson Lizardo]

---
 deviceinfo/deviceinfo.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/deviceinfo/deviceinfo.c b/deviceinfo/deviceinfo.c
index 6345f52..5dd9293 100644
--- a/deviceinfo/deviceinfo.c
+++ b/deviceinfo/deviceinfo.c
@@ -104,8 +104,8 @@ static void read_pnpid_cb(guint8 status, const guint8 *pdu, guint16 len,
 		return;
 	}
 
-	device_set_pnpid(ch->d->dev,value[0],att_get_u16(&value[1]),
-				att_get_u16(&value[3]),	att_get_u16(&value[5]));
+	device_set_pnpid(ch->d->dev, value[0], att_get_u16(&value[1]),
+				att_get_u16(&value[3]), att_get_u16(&value[5]));
 }
 
 static void process_deviceinfo_char(struct characteristic *ch)
-- 
1.7.5.4

[PATCH BlueZ 8/9] audio: Fix tab misuse

[Anderson Lizardo]

---
 audio/pcm_bluetooth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/audio/pcm_bluetooth.c b/audio/pcm_bluetooth.c
index 85566a3..b9da805 100644
--- a/audio/pcm_bluetooth.c
+++ b/audio/pcm_bluetooth.c
@@ -212,7 +212,7 @@ static void *playback_hw_thread(void *param)
 			char c = 'w';
 			int frags = periods - prev_periods, n;
 
-			data->hw_ptr += frags *	data->io.period_size;
+			data->hw_ptr += frags * data->io.period_size;
 			data->hw_ptr %= data->io.buffer_size;
 
 			for (n = 0; n < frags; n++) {
-- 
1.7.5.4

[PATCH BlueZ 9/9] hidd: Fix indentation

[Anderson Lizardo]

---
 compat/hidd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/compat/hidd.c b/compat/hidd.c
index fd1b28c..f8a0dfd 100644
--- a/compat/hidd.c
+++ b/compat/hidd.c
@@ -811,7 +811,7 @@ int main(int argc, char *argv[])
         if (detach) {
 		if (daemon(0, 0)) {
 			perror("Can't start daemon");
-        	        exit(1);
+			exit(1);
 		}
 	} else
 		log_option |= LOG_PERROR;
-- 
1.7.5.4

Re: [PATCH BlueZ 0/9] Fix indentation and tab misuse

[Anderson Lizardo]

On Fri, Apr 27, 2012 at 10:36 AM, Anderson Lizardo
<anderson.lizardo@openbossa.org> wrote:
> Hi,
>
> These are minor style fixes found "semi-automatically" while reviewing code.

BTW, sorry about the noise due to splitting these trivial fixes on
separate patches. I thought it would be better to have them separated
because they touch separate components. But as Johan pointed out on
IRC, for trivial fixes like these it is okay to send a single patch.

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil

Re: [PATCH BlueZ 0/9] Fix indentation and tab misuse

[Johan Hedberg]

Hi Lizardo,

On Fri, Apr 27, 2012, Anderson Lizardo wrote:
> Hi,
> 
> These are minor style fixes found "semi-automatically" while reviewing code.
> 
> Best Regards,
> 
> Anderson Lizardo (9):
>   lib: Fix tab misuse
>   tools: Fix tab misuse
>   event: Fix tab misuse
>   device: Fix tab misuse
>   sap: Fix tab misuse
>   monitor: Fix tab misuse
>   deviceinfo: Fix indentation and tab misuse
>   audio: Fix tab misuse
>   hidd: Fix indentation
> 
>  audio/pcm_bluetooth.c   |    2 +-
>  compat/hidd.c           |    2 +-
>  deviceinfo/deviceinfo.c |    4 ++--
>  lib/hci.c               |    2 +-
>  lib/hci_lib.h           |    2 +-
>  monitor/packet.c        |    2 +-
>  sap/server.c            |    2 +-
>  src/device.c            |    2 +-
>  src/event.c             |    2 +-
>  src/event.h             |    2 +-
>  tools/hciattach_ath3k.c |    2 +-
>  tools/sdptool.c         |    2 +-
>  12 files changed, 13 insertions(+), 13 deletions(-)

All patches in this set have been applied. Thanks.

Johan