From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Mat Martineau <mathewm@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, gustavo@padovan.org,
marcel@holtmann.org, pkrystad@codeaurora.org,
ulisses@profusion.mobi
Subject: Re: [PATCH 4/4] Bluetooth: Refactor L2CAP ERTM and streaming transmit segmentation
Date: Mon, 14 May 2012 12:52:46 +0300 [thread overview]
Message-ID: <20120514095244.GA10127@aemeltch-MOBL1> (raw)
In-Reply-To: <1335976922-19456-5-git-send-email-mathewm@codeaurora.org>
Hi Mat,
On Wed, May 02, 2012 at 09:42:02AM -0700, Mat Martineau wrote:
> Use more common code for ERTM and streaming mode segmentation and
> transmission, and begin using skb control block data for delaying
> extended or enhanced header generation until just before the packet is
> transmitted. This code is also better suited for resegmentation,
> which is needed when L2CAP links are reconfigured after an AMP channel
> move.
...
> @@ -1708,6 +1709,9 @@ static int l2cap_ertm_send(struct l2cap_chan *chan)
> if (chan->state != BT_CONNECTED)
> return -ENOTCONN;
>
> + if (test_bit(CONN_REMOTE_BUSY, &chan->conn_state))
> + return 0;
> +
> while ((skb = chan->tx_send_head) && (!l2cap_tx_window_full(chan))) {
We check here chan->tx_send_head. But:
...
> - skb_queue_splice_tail(&sar_queue, &chan->tx_q);
> - if (chan->tx_send_head == NULL)
> - chan->tx_send_head = sar_queue.next;
...
> -
> - if (chan->tx_send_head == NULL)
> - chan->tx_send_head = skb;
...
tx_send_head seems to be always NULL due to the change above. Have you
tested that it actually works?
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2012-05-14 9:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 16:41 [PATCH 0/4] ERTM state machine changes, part 2 Mat Martineau
2012-05-02 16:41 ` [PATCH 1/4] Bluetooth: Fix a redundant and problematic incoming MTU check Mat Martineau
2012-05-04 18:55 ` Ulisses Furquim
2012-05-04 20:39 ` Gustavo Padovan
2012-05-04 20:37 ` Gustavo Padovan
2012-05-02 16:42 ` [PATCH 2/4] Bluetooth: Restore locking semantics when looking up L2CAP channels Mat Martineau
2012-05-04 18:58 ` Ulisses Furquim
2012-05-02 16:42 ` [PATCH 3/4] Bluetooth: Lock the L2CAP channel when sending Mat Martineau
2012-05-04 19:06 ` Ulisses Furquim
2012-05-04 21:54 ` Mat Martineau
2012-05-05 1:11 ` Ulisses Furquim
2012-05-02 16:42 ` [PATCH 4/4] Bluetooth: Refactor L2CAP ERTM and streaming transmit segmentation Mat Martineau
2012-05-04 19:12 ` Ulisses Furquim
2012-05-04 20:57 ` Gustavo Padovan
2012-05-14 9:52 ` Andrei Emeltchenko [this message]
2012-05-14 15:47 ` Mat Martineau
2012-05-02 21:40 ` [PATCH 0/4] ERTM state machine changes, part 2 Mat Martineau
2012-05-04 19:10 ` Ulisses Furquim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514095244.GA10127@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mathewm@codeaurora.org \
--cc=pkrystad@codeaurora.org \
--cc=ulisses@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).