From: Johan Hedberg <johan.hedberg@gmail.com>
To: Alex Elsayed <eternaleye@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Add dbus service file that references the systemd unit
Date: Wed, 16 May 2012 11:01:34 +0300 [thread overview]
Message-ID: <20120516080134.GA27987@x220> (raw)
In-Reply-To: <6c5b002c86eeb1c83d4b7ca771e0f43ffaded710.1337072284.git.eternaleye@gmail.com>
Hi Alex,
On Tue, May 15, 2012, Alex Elsayed wrote:
> This allows bluez to be bus-activated.
> ---
> Makefile.am | 2 ++
> configure.ac | 2 +-
> src/org.bluez.service.in | 6 ++++++
> 3 files changed, 9 insertions(+), 1 deletion(-)
> create mode 100644 src/org.bluez.service.in
The patch looks ok'ish to me but you have to clean it up since it
doesn't apply:
Applying: Add dbus service file that references the systemd unit
/home/jh/src/bluez/.git/rebase-apply/patch:44: new blank line at EOF.
+
fatal: 1 line adds whitespace errors.
Patch failed at 0001 Add dbus service file that references the systemd unit
If you wanna catch this kind of stuff yourself in the future add the
following to your .gitconfig:
[apply]
whitespace = error
Johan
next prev parent reply other threads:[~2012-05-16 8:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 11:13 [PATCH] Add dbus service file that references the systemd unit Alex Elsayed
2012-05-16 8:01 ` Johan Hedberg [this message]
2012-05-16 20:53 ` [PATCH v2] " Alex Elsayed
2012-05-17 15:02 ` Johan Hedberg
2012-05-17 16:31 ` Alex Elsayed
2012-05-17 16:37 ` [PATCH v3] " Alex Elsayed
2012-05-17 16:43 ` [PATCH v2] " Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120516080134.GA27987@x220 \
--to=johan.hedberg@gmail.com \
--cc=eternaleye@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).