From: Johan Hedberg <johan.hedberg@gmail.com>
To: Alex Elsayed <eternaleye@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] Add dbus service file that references the systemd unit
Date: Thu, 17 May 2012 18:02:37 +0300 [thread overview]
Message-ID: <20120517150237.GA21315@x220.P-661HNU-F1> (raw)
In-Reply-To: <3bc04a064cb81285510d978c3c867e5ea5203600.1337201604.git.eternaleye@gmail.com>
Hi Alex,
On Wed, May 16, 2012, Alex Elsayed wrote:
> This allows bluez to be bus-activated.
>
> v2: Fix whitespace error
This v2 line shouldn't be part of the commit message. You can put stuff
like that between the --- line and the diff line (usually before the
diffstat).
> +++ b/src/org.bluez.service.in
> @@ -0,0 +1,5 @@
> +[D-BUS Service]
> +Name=org.bluez
> +Exec=@prefix@/sbin/bluetoothd -n
> +User=root
> +SystemdService=bluetooth.service
My Fedora 16 installation seems to provide its own org.bluez.service:
$ cat /usr/share/dbus-1/system-services/org.bluez.service
[D-BUS Service]
Name=org.bluez
Exec=/bin/false
User=root
SystemdService=dbus-org.bluez.service
Could you explain why it's a bit different from what you're providing
(particularly the /bin/false part). I'm not really an expert with with
systemd/D-Bus files so you'll need to convince me of why your variant is
correct (or more appropriate than the Fedora one) before it goes upstream.
Johan
next prev parent reply other threads:[~2012-05-17 15:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 11:13 [PATCH] Add dbus service file that references the systemd unit Alex Elsayed
2012-05-16 8:01 ` Johan Hedberg
2012-05-16 20:53 ` [PATCH v2] " Alex Elsayed
2012-05-17 15:02 ` Johan Hedberg [this message]
2012-05-17 16:31 ` Alex Elsayed
2012-05-17 16:37 ` [PATCH v3] " Alex Elsayed
2012-05-17 16:43 ` [PATCH v2] " Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120517150237.GA21315@x220.P-661HNU-F1 \
--to=johan.hedberg@gmail.com \
--cc=eternaleye@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox