linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH BlueZ] AVRCP: Remove unneeded check for set_volume callback
@ 2012-05-24 17:26 Lucas De Marchi
  2012-05-25  7:44 ` Johan Hedberg
  0 siblings, 1 reply; 2+ messages in thread
From: Lucas De Marchi @ 2012-05-24 17:26 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: luiz.dentz, Lucas De Marchi

---

Luiz, feel free to put this in your patchset if you prefer so it doesn't
conflict with your patches.

 audio/avrcp.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/audio/avrcp.c b/audio/avrcp.c
index cb6906d..7eda6e8 100644
--- a/audio/avrcp.c
+++ b/audio/avrcp.c
@@ -1150,8 +1150,7 @@ static gboolean avrcp_handle_volume_changed(struct avctp *session,
 	if (code == AVC_CTYPE_REJECTED || code == AVC_CTYPE_NOT_IMPLEMENTED)
 		return FALSE;
 
-	if (player->cb->set_volume != NULL)
-		player->cb->set_volume(abs_volume, player->dev, player->user_data);
+	player->cb->set_volume(abs_volume, player->dev, player->user_data);
 
 	return TRUE;
 }
-- 
1.7.10.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH BlueZ] AVRCP: Remove unneeded check for set_volume callback
  2012-05-24 17:26 [PATCH BlueZ] AVRCP: Remove unneeded check for set_volume callback Lucas De Marchi
@ 2012-05-25  7:44 ` Johan Hedberg
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2012-05-25  7:44 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: linux-bluetooth, luiz.dentz

Hi Lucas,

On Thu, May 24, 2012, Lucas De Marchi wrote:
> ---
> 
> Luiz, feel free to put this in your patchset if you prefer so it doesn't
> conflict with your patches.
> 
>  audio/avrcp.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

This didn't conflict with current git (with first three Luiz's patches)
so I went ahead and applied it.

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-05-25  7:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-24 17:26 [PATCH BlueZ] AVRCP: Remove unneeded check for set_volume callback Lucas De Marchi
2012-05-25  7:44 ` Johan Hedberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).