From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Define HCI AMP cmd struct
Date: Fri, 25 May 2012 14:44:46 +0300 [thread overview]
Message-ID: <20120525114445.GG3089@aemeltch-MOBL1> (raw)
In-Reply-To: <1337945351.15105.92.camel@aeonflux>
Hi Marcel,
On Fri, May 25, 2012 at 01:29:11PM +0200, Marcel Holtmann wrote:
> > +#define HCI_OP_DISC_PHY_LINK 0x0437
> > +struct hci_cp_disc_phy_link {
>
> we should use disconn or disconnect for this.
OK
> > +#define HCI_OP_READ_LOCAL_AMP_ASSOC 0x140a
> > +struct hci_cp_read_local_amp_assoc {
> > + __u8 handle;
> > + __le16 len_so_far;
> > + __le16 max_len;
> > +} __packed;
> > +
>
> No empty line here if the belong together.
OK
> > +#define HCI_EV_LOG_LINK_COMPLETE 0x45
> > +struct hci_ev_log_link_complete {
>
> Do you wanna go with log instead of logical. I would use logical to not
> get confused here.
OK
>
> > + __u8 status;
> > + __le16 log_handle;
>
> Just use handle here.
Ok, so I rename log_handle to handle and leave phy_handles as is.
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2012-05-25 11:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 11:13 [PATCH] Define AMP HCI commands Andrei Emeltchenko
2012-05-25 11:14 ` [PATCH] Bluetooth: Define HCI AMP cmd struct Andrei Emeltchenko
2012-05-25 11:29 ` Marcel Holtmann
2012-05-25 11:44 ` Andrei Emeltchenko [this message]
2012-05-25 12:09 ` Andrei Emeltchenko
2012-05-25 12:14 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525114445.GG3089@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox