From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Sasha Levin <levinsasha928@gmail.com>,
gustavo@padovan.org, johan.hedberg@gmail.com,
davem@davemloft.net, linux-bluetooth@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Bluetooth: Really fix registering hci with duplicate name
Date: Tue, 29 May 2012 10:48:31 +0300 [thread overview]
Message-ID: <20120529074829.GB15895@aemeltch-MOBL1> (raw)
In-Reply-To: <1338176868.15105.113.camel@aeonflux>
Hi,
On Mon, May 28, 2012 at 05:47:48AM +0200, Marcel Holtmann wrote:
> Hi Sasha,
>
> > Commit fc50744 ("Bluetooth: Fix registering hci with duplicate name") didn't
> > fully fix the duplicate naming issue with devices, and duplicate device names
> > could still be created:
> >
> > [ 142.484097] device: 'hci1': device_add
> > [...]
> > [ 150.545263] device: 'hci1': device_add
> > [ 150.550128] kobject: 'hci1' (ffff880014cc4e58): kobject_add_internal: parent: 'bluetooth', set: 'devices'
> > [ 150.558979] ------------[ cut here ]------------
> > [ 150.561438] WARNING: at fs/sysfs/dir.c:529 sysfs_add_one+0xb0/0xd0()
> > [ 150.572974] Hardware name: Bochs
> > [ 150.580502] sysfs: cannot create duplicate filename '/devices/virtual/bluetooth/hci1'
> > [ 150.584444] Pid: 7563, comm: trinity-child1 Tainted: G W 3.4.0-next-20120524-sasha #296
> > [...]
> >
> > Instead of the weird logic and the attempt at keeping the device list sorted,
> > just use an IDA.
> >
> > Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> > ---
> >
> > Changes from v1:
> >
> > - Address comments by Marcel.
> > - Remove errornous mutex lock.
> >
> > net/bluetooth/hci_core.c | 41 ++++++++++++++++++++++++-----------------
> > 1 files changed, 24 insertions(+), 17 deletions(-)
>
> thanks for addressing this. Patch has been applied to bluetooth-next
> tree.
The patch looks OK but I start to notice kmemleak messages like
shown below:
...
unreferenced object 0xf46e4ed8 (size 148):
comm "modprobe", pid 656, jiffies 4294900233 (age 4661.940s)
hex dump (first 32 bytes):
00 00 00 00 40 4e 6e f4 00 00 00 00 00 00 00 00 ....@Nn.........
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<c154dfcc>] kmemleak_alloc+0x3c/0xa0
[<c1132c7a>] kmem_cache_alloc+0x14a/0x190
[<c12af2dd>] idr_pre_get+0x5d/0x80
[<c12af3e5>] ida_pre_get+0x15/0x90
[<c12af497>] ida_simple_get+0x37/0xe0
[<f8369b79>] 0xf8369b79
[<f81be63e>] 0xf81be63e
[<c13f2a5e>] usb_probe_interface+0xce/0x210
[<c13733cb>] driver_probe_device+0x8b/0x370
[<c1373749>] __driver_attach+0x99/0xa0
[<c1371902>] bus_for_each_dev+0x42/0x70
[<c1372ea1>] driver_attach+0x21/0x30
[<c1372a47>] bus_add_driver+0x1c7/0x2e0
[<c1373bf6>] driver_register+0x66/0x110
[<c13f1acb>] usb_register_driver+0x7b/0x140
[<f8005017>] 0xf8005017
unreferenced object 0xf454c260 (size 148):
comm "modprobe", pid 656, jiffies 4294900233 (age 4661.940s)
hex dump (first 32 bytes):
00 00 00 00 d8 4e 6e f4 00 00 00 00 00 00 00 00 .....Nn.........
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<c154dfcc>] kmemleak_alloc+0x3c/0xa0
[<c1132c7a>] kmem_cache_alloc+0x14a/0x190
[<c12af2dd>] idr_pre_get+0x5d/0x80
[<c12af3e5>] ida_pre_get+0x15/0x90
[<c12af497>] ida_simple_get+0x37/0xe0
[<f8369b79>] 0xf8369b79
[<f81be63e>] 0xf81be63e
[<c13f2a5e>] usb_probe_interface+0xce/0x210
[<c13733cb>] driver_probe_device+0x8b/0x370
[<c1373749>] __driver_attach+0x99/0xa0
[<c1371902>] bus_for_each_dev+0x42/0x70
[<c1372ea1>] driver_attach+0x21/0x30
[<c1372a47>] bus_add_driver+0x1c7/0x2e0
[<c1373bf6>] driver_register+0x66/0x110
[<c13f1acb>] usb_register_driver+0x7b/0x140
[<f8005017>] 0xf8005017
...
Best regards
Andrei Emeltchenko
prev parent reply other threads:[~2012-05-29 7:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 20:36 [PATCH v2] Bluetooth: Really fix registering hci with duplicate name Sasha Levin
2012-05-28 3:47 ` Marcel Holtmann
2012-05-29 7:48 ` Andrei Emeltchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120529074829.GB15895@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=davem@davemloft.net \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=levinsasha928@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox