From: Johan Hedberg <johan.hedberg@gmail.com>
To: Ido Yariv <ido@wizery.com>
Cc: linux-bluetooth@vger.kernel.org,
Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
Subject: Re: [PATCH v3] gattrib: Fix a request/response command deadlock
Date: Wed, 30 May 2012 10:42:24 +0300 [thread overview]
Message-ID: <20120530074224.GD6539@x220> (raw)
In-Reply-To: <1338280763-3050-1-git-send-email-ido@wizery.com>
Hi Ido,
On Tue, May 29, 2012, Ido Yariv wrote:
> New requests and responses are never sent if a request was sent and the
> response for it hasn't been received yet. As a result, if both end
> points send requests at the same time, a deadlock could occur. This
> could happen, for instance, if the client sends a read request and the
> server sends an indication before responding to the read request.
>
> Fix this by introducing an additional queue for responses. Responses may
> be sent while there's still a pending request/indication.
> ---
> Changes from v2:
> - Cancel responses in g_attrib_cancel_all even if the requests queue is NULL
>
> attrib/gattrib.c | 111 ++++++++++++++++++++++++++++++++++++++++++------------
> 1 files changed, 87 insertions(+), 24 deletions(-)
Applied. Thanks.
Johan
prev parent reply other threads:[~2012-05-30 7:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 18:34 [PATCH] gattrib: Fix a request/response command deadlock Ido Yariv
2012-05-28 19:45 ` Vinicius Costa Gomes
2012-05-29 1:16 ` Ido Yariv
2012-05-29 1:20 ` [PATCH v2] " Ido Yariv
2012-05-29 2:40 ` Vinicius Costa Gomes
2012-05-29 8:39 ` [PATCH v3] " Ido Yariv
2012-05-29 13:59 ` Vinicius Costa Gomes
2012-05-30 7:42 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120530074224.GD6539@x220 \
--to=johan.hedberg@gmail.com \
--cc=ido@wizery.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=vinicius.gomes@openbossa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).