linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH BlueZ] core: Remove unneeded textfile header include
@ 2012-05-29 13:55 Claudio Takahasi
  2012-05-29 13:55 ` [PATCH BlueZ] GATT: Avoid unneeded discover transaction Claudio Takahasi
  2012-05-30  7:43 ` [PATCH BlueZ] core: Remove unneeded textfile header include Johan Hedberg
  0 siblings, 2 replies; 4+ messages in thread
From: Claudio Takahasi @ 2012-05-29 13:55 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Claudio Takahasi

---
 src/device.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/device.c b/src/device.c
index 0961ff6..7ff09aa 100644
--- a/src/device.c
+++ b/src/device.c
@@ -44,7 +44,6 @@
 #include <gdbus.h>
 
 #include "log.h"
-#include "textfile.h"
 
 #include "att.h"
 #include "hcid.h"
-- 
1.7.8.6


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH BlueZ] GATT: Avoid unneeded discover transaction
  2012-05-29 13:55 [PATCH BlueZ] core: Remove unneeded textfile header include Claudio Takahasi
@ 2012-05-29 13:55 ` Claudio Takahasi
  2012-05-30  7:43   ` Johan Hedberg
  2012-05-30  7:43 ` [PATCH BlueZ] core: Remove unneeded textfile header include Johan Hedberg
  1 sibling, 1 reply; 4+ messages in thread
From: Claudio Takahasi @ 2012-05-29 13:55 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Claudio Takahasi

This patch fix unneeded discover characteristics transaction when the
last characteristic declaration contains the handle number equals to the
end handle of the primary service.
---
 attrib/gatt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/attrib/gatt.c b/attrib/gatt.c
index b9c2bbb..6f9a11d 100644
--- a/attrib/gatt.c
+++ b/attrib/gatt.c
@@ -303,7 +303,7 @@ static void char_discovered_cb(guint8 status, const guint8 *ipdu, guint16 iplen,
 	att_data_list_free(list);
 	err = 0;
 
-	if (last != 0) {
+	if (last != 0 && (last + 1 < dc->end)) {
 		buf = g_attrib_get_buffer(dc->attrib, &buflen);
 
 		bt_uuid16_create(&uuid, GATT_CHARAC_UUID);
-- 
1.7.8.6


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH BlueZ] core: Remove unneeded textfile header include
  2012-05-29 13:55 [PATCH BlueZ] core: Remove unneeded textfile header include Claudio Takahasi
  2012-05-29 13:55 ` [PATCH BlueZ] GATT: Avoid unneeded discover transaction Claudio Takahasi
@ 2012-05-30  7:43 ` Johan Hedberg
  1 sibling, 0 replies; 4+ messages in thread
From: Johan Hedberg @ 2012-05-30  7:43 UTC (permalink / raw)
  To: Claudio Takahasi; +Cc: linux-bluetooth

Hi Claudio,

On Tue, May 29, 2012, Claudio Takahasi wrote:
> ---
>  src/device.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/src/device.c b/src/device.c
> index 0961ff6..7ff09aa 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -44,7 +44,6 @@
>  #include <gdbus.h>
>  
>  #include "log.h"
> -#include "textfile.h"
>  
>  #include "att.h"
>  #include "hcid.h"

Applied. Thanks.

Johan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH BlueZ] GATT: Avoid unneeded discover transaction
  2012-05-29 13:55 ` [PATCH BlueZ] GATT: Avoid unneeded discover transaction Claudio Takahasi
@ 2012-05-30  7:43   ` Johan Hedberg
  0 siblings, 0 replies; 4+ messages in thread
From: Johan Hedberg @ 2012-05-30  7:43 UTC (permalink / raw)
  To: Claudio Takahasi; +Cc: linux-bluetooth

Hi Claudio,

On Tue, May 29, 2012, Claudio Takahasi wrote:
> This patch fix unneeded discover characteristics transaction when the
> last characteristic declaration contains the handle number equals to the
> end handle of the primary service.
> ---
>  attrib/gatt.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied. Thanks.

Johan

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-05-30  7:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-29 13:55 [PATCH BlueZ] core: Remove unneeded textfile header include Claudio Takahasi
2012-05-29 13:55 ` [PATCH BlueZ] GATT: Avoid unneeded discover transaction Claudio Takahasi
2012-05-30  7:43   ` Johan Hedberg
2012-05-30  7:43 ` [PATCH BlueZ] core: Remove unneeded textfile header include Johan Hedberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).