From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 4/5] Bluetooth: Simplify a the connection type handling
Date: Thu, 31 May 2012 10:43:25 +0300 [thread overview]
Message-ID: <20120531074323.GC17461@aemeltch-MOBL1> (raw)
In-Reply-To: <1338423620-32578-4-git-send-email-vinicius.gomes@openbossa.org>
Hi Vinicius,
On Wed, May 30, 2012 at 09:20:19PM -0300, Vinicius Costa Gomes wrote:
> return add_le_conn(hdev, dst, dst_type, sec_level, auth_type);
> return add_acl_conn(hdev, dst, sec_level, auth_type);
> + return add_sco_conn(hdev, dst, sec_level, auth_type);
Those new functions are only ones missing hci prefix in that file? Maybe
names like hci_add_acl or hci_connect_acl would be better?
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2012-05-31 7:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 0:20 [PATCH 1/5] Bluetooth: Refactor LE connection into its own function Vinicius Costa Gomes
2012-05-31 0:20 ` [PATCH 2/5] Bluetooth: Refactor ACL " Vinicius Costa Gomes
2012-05-31 0:20 ` [PATCH 3/5] Bluetooth: Refactor SCO " Vinicius Costa Gomes
2012-05-31 0:20 ` [PATCH 4/5] Bluetooth: Simplify a the connection type handling Vinicius Costa Gomes
2012-05-31 7:39 ` Andrei Emeltchenko
2012-05-31 13:22 ` Gustavo Padovan
2012-05-31 17:27 ` Vinicius Costa Gomes
2012-05-31 7:43 ` Andrei Emeltchenko [this message]
2012-05-31 0:20 ` [PATCH 5/5] Bluetooth: Add type information to the hci_connect() debug statement Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531074323.GC17461@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=vinicius.gomes@openbossa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).