public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/3] Bluetooth: Change default MTU for L2CAP ATT channel
Date: Thu, 31 May 2012 10:33:10 -0300	[thread overview]
Message-ID: <20120531133310.GO18069@joana> (raw)
In-Reply-To: <1338401329-31429-1-git-send-email-andre.guedes@openbossa.org>

Hi Andre,

* Andre Guedes <andre.guedes@openbossa.org> [2012-05-30 15:08:47 -0300]:

> This patch changes the default MTU value for L2CAP ATT fixed channel
> to L2CAP_DEFAULT_MTU (672 octets).
> 
> Differently from others L2CAP channels, in L2CAP ATT fixed channel
> there is no MTU negotiation. The MTU value for that channel is up to
> the L2CAP implementation. The only restriction in L2CAP spec is the
> MTU value must not be less than 23 octets.
> 
> At ATT protocol level (on top of L2CAP), we have the ATT_MTU which
> defines the maximum size of any ATT message sent between client and
> server. GATT profile defines ATT_MTU default value to 23 octets. If
> a GATT based profile wants to use ATT_MTU greater than 23 octets
> (e.g. HID over GATT profile), it should negotiate a new value by
> executing the GATT Exchange MTU sub-procedure.
> 
> Thus, in order to support any value of ATT_MTU negotiated at ATT
> protocol level, our L2CAP implementation should have L2CAP ATT
> fixed channel MTU equal or greater than ATT_MAX_MTU (512 octets).

Shouldn't we define a L2CAP_LE_MAX_MTU then and set its value to 512?
If we will never have anything greater than 512 octets why allow it?

	Gustavo

  parent reply	other threads:[~2012-05-31 13:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30 18:08 [PATCH 1/3] Bluetooth: Change default MTU for L2CAP ATT channel Andre Guedes
2012-05-30 18:08 ` [PATCH 2/3] Bluetooth: Check MTU value in l2cap_sock_setsockopt_old Andre Guedes
2012-05-31 13:42   ` Gustavo Padovan
2012-05-31 19:08     ` Andre Guedes
2012-05-30 18:08 ` [PATCH 3/3] Bluetooth: Rename L2CAP_LE_DEFAULT_MTU Andre Guedes
2012-05-31 13:33 ` Gustavo Padovan [this message]
2012-05-31 19:08   ` [PATCH 1/3] Bluetooth: Change default MTU for L2CAP ATT channel Andre Guedes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120531133310.GO18069@joana \
    --to=gustavo@padovan.org \
    --cc=andre.guedes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox