From: Ido Yariv <ido@wizery.com>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] attrib-server: Fix multiple channels detaching mix-up
Date: Wed, 6 Jun 2012 12:18:11 +0300 [thread overview]
Message-ID: <20120606091758.GA12782@WorkStation.localnet> (raw)
In-Reply-To: <20120530183227.GA16709@WorkStation.localnet>
Hi Johan,
On Wed, May 30, 2012 at 09:32:27PM +0300, Ido Yariv wrote:
> From 78254bb099f80ad38e10075fbb73a4d990217630 Mon Sep 17 00:00:00 2001
> From: Ido Yariv <ido@wizery.com>
> Date: Tue, 29 May 2012 21:11:16 +0300
> Subject: [PATCH v2] attrib-server: Fix multiple channels detaching mix-up
>
> The identifier returned by g_attrib_register is not unique across
> different channels. Since attrib_channel_detach assumes this identifier
> to be unique, it may end up detaching the wrong channel when a device
> disconnects.
>
> Fix this by using the channel's pointer as a unique identifier for
> detaching the channel. The identifier returned from g_attrib_register
> will still be used to find the relevant event structure.
Any thoughts about this one?
Thanks,
Ido.
next prev parent reply other threads:[~2012-06-06 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 20:20 [PATCH] attrib-server: Fix multiple channels detaching mix-up Ido Yariv
2012-05-30 7:37 ` Johan Hedberg
2012-05-30 18:32 ` Ido Yariv
2012-06-06 9:18 ` Ido Yariv [this message]
2012-06-07 15:44 ` Johan Hedberg
2012-06-08 15:39 ` Johan Hedberg
2012-06-08 16:01 ` Ido Yariv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120606091758.GA12782@WorkStation.localnet \
--to=ido@wizery.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).