From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC 1/8] gattrib: Fix GAttrib buffer allocation
Date: Thu, 7 Jun 2012 15:03:39 +0800 [thread overview]
Message-ID: <20120607070339.GA11609@x220> (raw)
In-Reply-To: <1339029663-25654-1-git-send-email-andre.guedes@openbossa.org>
Hi Andre,
On Wed, Jun 06, 2012, Andre Guedes wrote:
> GAttrib buffer should be allocated according to ATT_MTU value. Over
> BR/EDR, ATT_MTU should be set to the L2CAP imtu negotiated during
> L2CAP configuration phase. Over LE, ATT_MTU should be 23 octets.
> ---
> attrib/gattrib.c | 32 ++++++++++++++++++++------------
> 1 file changed, 20 insertions(+), 12 deletions(-)
I've applied all patches as they look ok and the behavior can't get
much more broken than it was previously. I'll also continue testing them
at the UPF and do/propose additional fixes if necessary.
Johan
next prev parent reply other threads:[~2012-06-07 7:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 0:40 [RFC 1/8] gattrib: Fix GAttrib buffer allocation Andre Guedes
2012-06-07 0:40 ` [RFC 2/8] gattrib: Fix g_attrib_set_mtu Andre Guedes
2012-06-07 1:26 ` Anderson Lizardo
2012-06-07 20:13 ` Andre Guedes
2012-06-07 0:40 ` [RFC 3/8] attrib-server: Fix gatt_channel MTU value Andre Guedes
2012-06-07 0:40 ` [RFC 4/8] attrib-server: Fix mtu_exchange Andre Guedes
2012-06-07 0:41 ` [RFC 5/8] attrib-server: Update GAttrib buffer after Exchange MTU Andre Guedes
2012-06-07 0:41 ` [RFC 6/8] Remove omtu parameter from LE bt_io_connect calls Andre Guedes
2012-06-07 0:41 ` [RFC 7/8] Fix gatt_connect for BR/EDR Andre Guedes
2012-06-07 0:41 ` [RFC 8/8] Remove workaround in gatt_connect Andre Guedes
2012-06-07 7:03 ` Johan Hedberg [this message]
2012-06-07 13:13 ` [RFC 1/8] gattrib: Fix GAttrib buffer allocation Anderson Lizardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607070339.GA11609@x220 \
--to=johan.hedberg@gmail.com \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).