From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: Szymon Janc <szymon.janc@tieto.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCHv2 3/5] Bluetooth: Add opcode to error message
Date: Mon, 11 Jun 2012 11:06:18 +0300 [thread overview]
Message-ID: <20120611080611.GA29187@aemeltch-MOBL1> (raw)
In-Reply-To: <201206081317.42898.szymon.janc@tieto.com>
Hi Szymon,
On Fri, Jun 08, 2012 at 01:17:42PM +0200, Szymon Janc wrote:
> > - BT_ERR("%s command tx timeout", hdev->name);
> > + if (hdev->sent_cmd) {
> > + struct hci_command_hdr *sent = (void *) hdev->sent_cmd->data;
> > + u16 opcode = __le16_to_cpu(sent->opcode);
> > +
> > + BT_ERR("%s command 0x%4.4x tx timeout", hdev->name, opcode);
> > + } else
> > + BT_ERR("%s command tx timeout", hdev->name);
> > +
>
> Just a minor, 'else' should have braces as well.
Sure, thanks for pointing out. I will send updated version soon.
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2012-06-11 8:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 8:12 [PATCHv1 1/4] Bluetooth: Use standard HCI cmd timeout for RESET Andrei Emeltchenko
2012-06-08 8:12 ` [PATCHv1 2/4] Bluetooth: Add opcode to error message Andrei Emeltchenko
2012-06-08 8:12 ` [PATCHv1 3/4] Bluetooth: Add debug print specifier Andrei Emeltchenko
2012-06-08 8:34 ` Marcel Holtmann
2012-06-08 8:12 ` [PATCHv1 4/4] Bluetooth: Fix not setting HCI_RESET flag for AMP Andrei Emeltchenko
2012-06-08 8:31 ` [PATCHv1 1/4] Bluetooth: Use standard HCI cmd timeout for RESET Marcel Holtmann
2012-06-08 8:53 ` Andrei Emeltchenko
2012-06-08 9:00 ` Andrei Emeltchenko
2012-06-08 9:01 ` Marcel Holtmann
2012-06-08 9:00 ` Marcel Holtmann
2012-06-08 9:11 ` Szymon Janc
2012-06-08 11:03 ` [PATCHv2 1/5] " Andrei Emeltchenko
2012-06-08 11:03 ` [PATCHv2 2/5] Bluetooth: Update HCI timeouts constants to use msecs_to_jiffies Andrei Emeltchenko
2012-06-08 11:03 ` [PATCHv2 3/5] Bluetooth: Add opcode to error message Andrei Emeltchenko
2012-06-08 11:17 ` Szymon Janc
2012-06-11 8:06 ` Andrei Emeltchenko [this message]
2012-06-08 11:03 ` [PATCHv2 4/5] Bluetooth: Correct debug print specifier for u16 objects Andrei Emeltchenko
2012-06-08 11:03 ` [PATCHv2 5/5] Bluetooth: Fix not setting HCI_RESET flag for AMP Andrei Emeltchenko
2012-06-11 8:13 ` [PATCHv3 1/5] Bluetooth: Use standard HCI cmd timeout for RESET Andrei Emeltchenko
2012-06-11 8:13 ` [PATCHv3 2/5] Bluetooth: Update HCI timeouts constants to use msecs_to_jiffies Andrei Emeltchenko
2012-06-11 8:13 ` [PATCHv3 3/5] Bluetooth: Add opcode to error message Andrei Emeltchenko
2012-06-11 8:13 ` [PATCHv3 4/5] Bluetooth: Correct debug print specifier for u16 objects Andrei Emeltchenko
2012-06-11 8:13 ` [PATCHv3 5/5] Bluetooth: Fix not setting HCI_RESET flag for AMP Andrei Emeltchenko
2012-06-12 3:15 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611080611.GA29187@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=szymon.janc@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox