From: Johan Hedberg <johan.hedberg@gmail.com>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: Joao Paulo Rechi Vita <jprvita@openbossa.org>,
Henrique Dante <hdante@profusion.mobi>,
Anderson Lizardo <anderson.lizardo@openbossa.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH RFC] gdbus: Rename variables named "signal" (so that it can be compiled with -Wshadow)
Date: Wed, 20 Jun 2012 12:41:04 +0300 [thread overview]
Message-ID: <20120620094104.GA17914@x220> (raw)
In-Reply-To: <CAMOw1v7ZfiuMxXhXRo2RcB7-WK21gbfip3hXTuRYy=WCj2iaAQ@mail.gmail.com>
Hi Lucas,
On Tue, Jun 19, 2012, Lucas De Marchi wrote:
> >>>> Would it be interesting to add this option to acinclude.m4? Or does it
> >>>> generate too much noise?
> >>>
> >>> It generates few warnings. Depending on the acceptance of this patch,
> >>> I could fix bluez as a whole and add -Wshadow to acinclude.m4.
> >>
> >> Actually, I had a partial build here. Ignore the previous answer, it
> >> generates a lot of warnings.
> >>
> >
> > If we're not going to enable -Wshadow by default, does it make sense
> > to apply this patch? Who is going to check if no new shadow warnings
> > are being inserted in new commits?
>
> I'm all for doing the following:
>
> 1) Fix all the places with shadow variables
> 2) Add -Wshadow to the warning flags
>
> There are lots of them.
Agreed. This could be one of the targets before releasing BlueZ 5.0.
Johan
next prev parent reply other threads:[~2012-06-20 9:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 12:04 [PATCH RFC] gdbus: Rename variables named "signal" (so that it can be compiled with -Wshadow) Henrique Dante de Almeida
2012-06-15 12:29 ` Anderson Lizardo
2012-06-15 12:43 ` Henrique Dante
2012-06-15 12:45 ` Henrique Dante
2012-06-19 18:29 ` Joao Paulo Rechi Vita
2012-06-19 21:41 ` Lucas De Marchi
2012-06-20 9:41 ` Johan Hedberg [this message]
2012-06-20 13:20 ` Joao Paulo Rechi Vita
2012-06-20 13:59 ` Joao Paulo Rechi Vita
2012-06-22 21:10 ` Henrique Dante
2012-06-15 15:27 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620094104.GA17914@x220 \
--to=johan.hedberg@gmail.com \
--cc=anderson.lizardo@openbossa.org \
--cc=hdante@profusion.mobi \
--cc=jprvita@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).