From: Andrew Morton <akpm@linux-foundation.org>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [PATCH] Docs: printk-formats: add description for %pMR
Date: Wed, 20 Jun 2012 14:19:57 -0700 [thread overview]
Message-ID: <20120620141957.d865133a.akpm@linux-foundation.org> (raw)
In-Reply-To: <1340189089-20257-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
On Wed, 20 Jun 2012 13:44:49 +0300
Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com> wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> Add information about new specifier %pMR for Bluetooth addresses.
>
> ...
>
> --- a/Documentation/printk-formats.txt
> +++ b/Documentation/printk-formats.txt
> @@ -56,6 +56,7 @@ Struct Resources:
> MAC/FDDI addresses:
>
> %pM 00:01:02:03:04:05
> + %pMR 05:04:03:02:01:00
> %pMF 00-01-02-03-04-05
> %pm 000102030405
>
> @@ -67,6 +68,10 @@ MAC/FDDI addresses:
> the 'M' specifier to use dash ('-') separators instead of the default
> separator.
>
> + For Bluetooth addresses the 'R' specifier shall be used after the 'M'
> + specifier to use reversed byte order suitable for visual interpretation
> + of Bluetooth addresses which are in the little endian order.
> +
huh, I didn't know about that file, or I forgot about it. I wonder if
it is otherwise up to date.
Do we really need it? If we can sufficiently document the printk
formats in lib/vsprintf.c then let's remove
Documentation/printk-formats.txt. Otherwise, I shall do this:
--- a/lib/vsprintf.c
+++ a/lib/vsprintf.c
@@ -1297,6 +1297,8 @@ qualifier:
* case.
* %n is ignored
*
+ * ** Please update Documentation/printk-formats.txt when making changes **
+ *
* The return value is the number of characters which would
* be generated for the given input, excluding the trailing
* '\0', as per ISO C99. If you want to have the exact
_
next prev parent reply other threads:[~2012-06-20 21:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-04 2:33 [PATCH 0/2] Add and use vsprintf extension %pMbt for bluetooth macs Joe Perches
2010-12-04 2:33 ` [PATCH 2/2] bluetooth: Use printf extension %pMbt Joe Perches
2010-12-06 18:15 ` Gustavo F. Padovan
2010-12-06 18:50 ` Joe Perches
2010-12-06 20:07 ` Gustavo F. Padovan
2012-05-09 9:01 ` [PATCH 0/2] Add and use vsprintf extension %pMbt for bluetooth macs Andrei Emeltchenko
2012-05-11 23:21 ` Joe Perches
2012-05-25 14:32 ` [RFC] vsprintf: Add %pMR for Bluetooth MAC address andrei.emeltchenko.news
2012-05-25 14:37 ` Gustavo Padovan
2012-05-25 15:07 ` Joe Perches
2012-05-28 9:00 ` [PATCHv2] " Andrei Emeltchenko
2012-05-28 10:01 ` Andy Shevchenko
2012-05-28 10:20 ` Andrei Emeltchenko
2012-05-28 13:05 ` [PATCHv3] " Andrei Emeltchenko
2012-06-05 11:57 ` Andrei Emeltchenko
2012-06-20 10:44 ` [PATCH] Docs: printk-formats: add description for %pMR Andrei Emeltchenko
2012-06-20 21:19 ` Andrew Morton [this message]
2012-06-21 7:08 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620141957.d865133a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).