Re: [PATCH] Docs: printk-formats: add description for %pMR

[Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>]

Hi,

On Wed, Jun 20, 2012 at 02:19:57PM -0700, Andrew Morton wrote:
> > --- a/Documentation/printk-formats.txt
> > +++ b/Documentation/printk-formats.txt
> > @@ -56,6 +56,7 @@ Struct Resources:
> >  MAC/FDDI addresses:
> >  
> >  	%pM	00:01:02:03:04:05
> > +	%pMR	05:04:03:02:01:00
> >  	%pMF	00-01-02-03-04-05
> >  	%pm	000102030405
> >  
> > @@ -67,6 +68,10 @@ MAC/FDDI addresses:
> >  	the 'M' specifier to use dash ('-') separators instead of the default
> >  	separator.
> >  
> > +	For Bluetooth addresses the 'R' specifier shall be used after the 'M'
> > +	specifier to use reversed byte order suitable for visual interpretation
> > +	of Bluetooth addresses which are in the little endian order.
> > +
> 
> huh, I didn't know about that file, or I forgot about it.

This happens also to me.

> I wonder if it is otherwise up to date.
> Do we really need it?  

I feel that the document is very good.

> If we can sufficiently document the printk
> formats in lib/vsprintf.c then let's remove
> Documentation/printk-formats.txt.  

Until I read that vsprintf.c I did not know where to find printk format
specifiers. It does make sense to keep it.

> Otherwise, I shall do this:
> 
> 
> --- a/lib/vsprintf.c
> +++ a/lib/vsprintf.c
> @@ -1297,6 +1297,8 @@ qualifier:
>   *   case.
>   * %n is ignored
>   *
> + * ** Please update Documentation/printk-formats.txt when making changes **
> + *

Looks good.

Best regards 
Andrei Emeltchenko