linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Bartosz Szatkowski <bulislaw@linux.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ v2 1/3] Add SetRemoteProperties method for OOB COD setting
Date: Thu, 28 Jun 2012 14:33:21 +0300	[thread overview]
Message-ID: <20120628113321.GA18209@x220> (raw)
In-Reply-To: <1314014944-21554-1-git-send-email-bulislaw@linux.com>

Hi Bartosz (and whoever is interested in OOB pairing),

On Mon, Aug 22, 2011, Bartosz Szatkowski wrote:
> Add method for suppling class of device through OOB mechanism, to be
> available at pairing phase. At this point it may be presented to the
> user, by agent, in confirmation request (or whatever).
> ---
>  doc/oob-api.txt   |   13 ++++
>  plugins/dbusoob.c |  164 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 177 insertions(+), 0 deletions(-)

These patches never went upstream but I'd like to revive the discussion
around them.

> diff --git a/doc/oob-api.txt b/doc/oob-api.txt
> index d838712..0324758 100644
> --- a/doc/oob-api.txt
> +++ b/doc/oob-api.txt
> @@ -36,3 +36,16 @@ Methods		array{byte} hash, array{byte} randomizer ReadLocalData()
>  
>  			Possible errors: org.bluez.Error.Failed
>  					 org.bluez.Error.InvalidArguments
> +
> +		void SetRemoteProperties(string address, dict data)
> +
> +			This method set new properties for device with specified
> +			address, to be used when device is created.
> +			On success DeviceFound signal will be emitted.
> +
> +			Currently supported keys:
> +
> +				Class		uint32
> +
> +			Possible errors: org.bluez.Error.Failed
> +					 org.bluez.Error.InvalidArguments

Now that we're starting to prepare BlueZ 5 we can make more radical
changes to the D-Bus APIs. E.g. I don't think we need a separate
SetRemoteProperties method but the existing AddRemoteData one could
simply be changed to take a dictionary which would usually just include
the keys "Randomizer" and "Hash" but could also include other info like
"Class".

Thoughts? Is anyone actually actively using the current OutOfBand D-Bus
interface?

Johan

  parent reply	other threads:[~2012-06-28 11:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22 12:09 [PATCH BlueZ v2 1/3] Add SetRemoteProperties method for OOB COD setting Bartosz Szatkowski
2011-08-22 12:09 ` [PATCH BlueZ v2 2/3] Add support for OOB data in SetRemoteProperties Bartosz Szatkowski
2011-08-22 12:09 ` [PATCH BlueZ v2 3/3] Add support for name in OOB SetRemoteProperties Bartosz Szatkowski
2012-06-28 11:33 ` Johan Hedberg [this message]
2012-07-23 11:15   ` Re: [PATCH BlueZ v2 1/3] Add SetRemoteProperties method for OOB COD setting Szymon Janc
  -- strict thread matches above, loose matches on Subject: below --
2011-08-22 11:39 Bartosz Szatkowski
2011-08-22 11:50 ` Bartosz Szatkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120628113321.GA18209@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=bulislaw@linux.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).