From: Johan Hedberg <johan.hedberg@gmail.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/3] fakehid: Disconnect from PS3 remote after 10 mins
Date: Fri, 29 Jun 2012 14:35:46 +0300 [thread overview]
Message-ID: <20120629113546.GC24842@x220> (raw)
In-Reply-To: <1340027876.3987.117.camel@novo.hadess.net>
Hi Bastien,
On Mon, Jun 18, 2012, Bastien Nocera wrote:
> > It doesn't really need to remove/add the timeout separately, upon
> > event just reset the idle timeout.
>
> I don't understand what you're saying here.
>
> Are you saying I should call g_source_remove, and then g_timeout_add()?
> There's no functionality to change the interval for g_timeout_add*
> functions.
>
> The call is separate because it is used multiple times in the code (and
> handling getting/setting in one place is cleaner).
>
> By the way, the reason why it's handled this way is because the rest of
> the input code relies on the kernel switching off the connection using
> hidp_connadd_req->idle_to. fakehid doesn't use hidp.
Luiz told me that you had some IRC discussion about this and came to
some sort of consensus. Should I be expecting a new patch set?
Johan
next prev parent reply other threads:[~2012-06-29 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-16 23:32 [PATCH 2/3] fakehid: Disconnect from PS3 remote after 10 mins Bastien Nocera
2012-06-18 8:44 ` Luiz Augusto von Dentz
2012-06-18 13:57 ` Bastien Nocera
2012-06-29 11:35 ` Johan Hedberg [this message]
2012-06-29 11:46 ` Bastien Nocera
2012-06-29 14:50 ` Luiz Augusto von Dentz
-- strict thread matches above, loose matches on Subject: below --
2012-09-07 11:01 Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120629113546.GC24842@x220 \
--to=johan.hedberg@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox