From: Gustavo Padovan <gustavo@padovan.org>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv2] Bluetooth: btmrvl: Do not send vendor events to bluetooth stack
Date: Sat, 30 Jun 2012 12:28:56 -0300 [thread overview]
Message-ID: <20120630152856.GE1920@joana> (raw)
In-Reply-To: <20120629142330.GB8718@aemeltch-MOBL1>
Hi Andrei,
* Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com> [2012-06-29 17:23:32 +0300]:
> Hi Johan,
>
> On Fri, Jun 29, 2012 at 05:06:35PM +0300, Johan Hedberg wrote:
> > Hi Andrei,
> >
> > On Thu, Jun 28, 2012, Andrei Emeltchenko wrote:
> > > On Tue, Jun 19, 2012 at 12:26:30AM -0300, Gustavo Padovan wrote:
> > > > Hi Andrei,
> > > >
> > > > * Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com> [2012-06-15 09:10:54 +0300]:
> > > >
> > > > > From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> > > > >
> > > > > Vendor-specific events shall be processed in driver and not sent
> > > > > to bluetooth stack where they screw up HCI command countings.
> > > > >
> > > > > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> > > > > Tested-by: Bing Zhao <bzhao@marvell.com>
> > > > > ---
> > > > > drivers/bluetooth/btmrvl_drv.h | 2 +-
> > > > > drivers/bluetooth/btmrvl_main.c | 18 +++++++++++++++---
> > > > > drivers/bluetooth/btmrvl_sdio.c | 9 ++++++---
> > > > > 3 files changed, 22 insertions(+), 7 deletions(-)
> > > >
> > > > Patch has been applied to the bluetooth tree. Thanks.
> > >
> > > Which version have you applied? Old one?
> >
> > The patch that's upstream doesn't have the Tested-by tag so it seems
> > Gustavo might have applied the old version of the patch instead of v2.
> > Could you confirm?
>
> Yes, there is old version. Apart from missing Tested-by tag there is one
> style issue, debug issue and variable scope change which do not affect
> functionality though.
>
> If that patch would applied to bluetooth-next first I would notice that
> much earlier...
This patch already went to wireless, so I can't change it anymore, can you
send a delta patch with the fixes that are in v2?
Gustavo
next prev parent reply other threads:[~2012-06-30 15:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 10:35 [RFC] Bluetooth: btmrvl: Do not send vendor events to bluetooth stack Andrei Emeltchenko
2012-06-14 18:11 ` Bing Zhao
2012-06-15 6:10 ` [PATCHv2] " Andrei Emeltchenko
2012-06-19 3:26 ` Gustavo Padovan
2012-06-28 13:48 ` Andrei Emeltchenko
2012-06-29 14:06 ` Johan Hedberg
2012-06-29 14:23 ` Andrei Emeltchenko
2012-06-30 15:28 ` Gustavo Padovan [this message]
2012-07-09 10:57 ` [PATCH] Bluetooth: btmrvl: trivial style fixes Andrei Emeltchenko
2012-07-09 12:48 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120630152856.GE1920@joana \
--to=gustavo@padovan.org \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).