From: Johan Hedberg <johan.hedberg@gmail.com>
To: "Frédéric Danis" <frederic.danis@linux.intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v12 13/13] audio: Add fast connectable to telephony interface
Date: Tue, 17 Jul 2012 11:10:21 +0300 [thread overview]
Message-ID: <20120717081021.GB368@x220> (raw)
In-Reply-To: <1342090438-20434-14-git-send-email-frederic.danis@linux.intel.com>
Hi Frédéric,
On Thu, Jul 12, 2012, Frédéric Danis wrote:
> +# Telephony interface specific options (i.e. options which affect how the
> +# service interacts with remote devices)
> +[Telephony]
> +
> +# Set to true to enable agent to use of fast connectable mode (faster page
> +# scanning) when incoming call starts. Default settings should be restored
> +# after call is answered or rejected. Page scan interval is much shorter and
> +# page scan type changed to interlaced. Such allows faster connection
> +# initiated by a headset.
> +FastConnectable=false
I don't really see the point of making this configurable and add extra
code complexity because of it. There should be no reason why it couldn't
always be available to the telephony agent. So unless you have a really
good reason for keeping it could you please remove it.
Johan
next prev parent reply other threads:[~2012-07-17 8:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 10:53 [PATCH v12 00/13] Add org.bluez.Telephony interface Frédéric Danis
2012-07-12 10:53 ` [PATCH v12 01/13] audio: Move telephony drivers to D-Bus interface Frédéric Danis
2012-07-17 8:08 ` Johan Hedberg
2012-07-17 8:21 ` Frederic Danis
2012-07-12 10:53 ` [PATCH v12 02/13] audio: Simplify org.bluez.Headset Frédéric Danis
2012-07-12 10:53 ` [PATCH v12 03/13] audio: Remove dummy telephony driver Frédéric Danis
2012-07-12 10:53 ` [PATCH v12 04/13] audio: Remove maemo5 " Frédéric Danis
2012-07-12 10:53 ` [PATCH v12 05/13] audio: Remove maemo6 " Frédéric Danis
2012-07-12 10:53 ` [PATCH v12 06/13] audio: Remove oFono " Frédéric Danis
2012-07-12 10:53 ` [PATCH v12 07/13] audio: Move HFP/HSP AG servers to telephony.c Frédéric Danis
2012-07-12 10:53 ` [PATCH v12 08/13] audio: Send transport path to telephony agent Frédéric Danis
2012-07-12 10:53 ` [PATCH v12 09/13] audio: Move HFP HF server to telephony.c Frédéric Danis
2012-07-12 10:53 ` [PATCH v12 10/13] audio: Replace headset and gateway by telephony Frédéric Danis
2012-07-12 10:53 ` [PATCH v12 11/13] audio: Add DUN GW to org.bluez.Telephony Frédéric Danis
2012-07-12 10:53 ` [PATCH v12 12/13] audio: Add SAP " Frédéric Danis
2012-07-12 10:53 ` [PATCH v12 13/13] audio: Add fast connectable to telephony interface Frédéric Danis
2012-07-17 8:10 ` Johan Hedberg [this message]
2012-07-17 8:23 ` Frederic Danis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717081021.GB368@x220 \
--to=johan.hedberg@gmail.com \
--cc=frederic.danis@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).